Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 20:18:31 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     K Prateek Nayak <kprateek.nayak@amd.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Mel Gorman <mgorman@suse.de>, Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Barry Song <21cnbao@gmail.com>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Len Brown <len.brown@intel.com>,
        Ben Segall <bsegall@google.com>,
        Aubrey Li <aubrey.li@intel.com>,
        Abel Wu <wuyun.abel@bytedance.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Tim Chen <tim.c.chen@intel.com>, linux-kernel@vger.kernel.org,
        Yicong Yang <yangyicong@hisilicon.com>,
        Mohini Narkhede <mohini.narkhede@intel.com>
Subject: Re: [PATCH v4] sched/fair: Introduce SIS_UTIL to search idle CPU
 based on sum of util_avg
Message-ID: <20220624121831.GA5570@chenyu5-mobl1>
References: <20220612163428.849378-1-yu.c.chen@intel.com>
 <76c94a3b-6ca2-e0e2-c618-42b147d2737d@amd.com>
 <YrVn9t2kLHB21uG1@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YrVn9t2kLHB21uG1@hirez.programming.kicks-ass.net>
Precedence: bulk

On Fri, Jun 24, 2022 at 09:29:58AM +0200, Peter Zijlstra wrote:
> On Wed, Jun 22, 2022 at 12:06:55PM +0530, K Prateek Nayak wrote:
> > Hello Chenyu,
> > 
> > I'm sorry for the delay. The testing took a while but below are
> > the results from testing on our system.
> > 
> > tl;dr
> > 
> > o We ran all the tests with with SIS_PROP disabled.
> > o tbench reaches close to saturation early with 256 clients.
> > o schbench shows improvements for low worker counts.
> > o All other benchmark results seem comparable to tip.
> >   We don't see any serious regressions with v4.
> > 
> > > @@ -61,6 +61,7 @@ SCHED_FEAT(TTWU_QUEUE, true)
> > >   * When doing wakeups, attempt to limit superfluous scans of the LLC domain.
> > >   */
> > >  SCHED_FEAT(SIS_PROP, true)
> > 
> > SIS_PROP was disabled in our testing as follows:
> > 
> > --
> > -SCHED_FEAT(SIS_PROP, true)
> > +SCHED_FEAT(SIS_PROP, false)
> 
> So how about I make this change.
> 
> > With v4 on the current tip, I don't see any need for
> > a special case for systems with smaller LLCs with
> > SIS_PROP disabled and SIS_UITL enable. Even SIS Efficiency
> > seems to be better with SIS_UTIL for hackbench.
> > 
> > Tested-by: K Prateek Nayak <kprateek.nayak@amd.com> 
> 
> And apply this thing, lets see how it fares..

OK, thanks, Peter.


Best,
Chenyu