Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp354569iog; Fri, 24 Jun 2022 05:29:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vY4e0oCffSmxQicyFcm1AFJvuTJ7O6zRl+mOcbWUnqXIzyPtpNLrv7gxvrj9b6XZZmfyW4 X-Received: by 2002:a17:907:7f1d:b0:722:f2fe:8eaf with SMTP id qf29-20020a1709077f1d00b00722f2fe8eafmr12265472ejc.279.1656073759627; Fri, 24 Jun 2022 05:29:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656073759; cv=none; d=google.com; s=arc-20160816; b=hBNjgVtxFYHhEG/kQU1anrTRhut5mpLBbbxCGN8KAkXfQI/0I1Wd6jB/rQ6vB1z7s2 r5sHYAzHMcMz34rYm5LMCODH31rLGu081kF0s9MAgorWhP4RXwupfrpmMSj5/Neo821x ChKWWxwHyTlq1RQgHee4OnDU3jv37TwE61wqRdcRULb8moB8z5RvnYWSxl8OJTK4f5wf lPveM+yTWHylVu2hx8xVu7XrUov+QOni09cPvPJCoqH6jlDC0abvjKg3mmgxoWMcdvZp 6uNoh06CWw6GSWhE/i16Jz/xgxZAzhVDBGFHuerfRVEsXPQ64CeTJidwBCbhDv9wT/DI E1yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pc8UKkAsxy+drOm1cyl5G/M+G6/DZKYcpaz2NiSvhus=; b=OotFQgZZhFVZLWhriwWS3jRneiMbxC14XyqAbPUmrCLjIQq6SC6KdqKzDu00qo3mAB /2E9mWzSObYmt96rWi/+iccy/F2zWBhfYUfyLj5xGebuWklxrCPU6jT/DWzsNcXejbXL lR3PbMUXTTt916ircRgyBtdZeqnIjkAul0vycUoEMc+2VbDnn8gTyyj4Us7UHc38xJ1x EJSFyw/DvmDvqCsgERI7WCCNpm4FBOb6fiDUf/QcBBbEXZ4Bw1IxABb95f4JJ2WUC4jd as9UNBLKoDJ5ksUZsz2A3huK52GfvCP9K1FWr32hBDXuPf+blDAPVUcBBOOmVfkb7Jy2 vijw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WJFZhNsH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hd38-20020a17090796a600b0071221a82fd9si2965142ejc.925.2022.06.24.05.28.54; Fri, 24 Jun 2022 05:29:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WJFZhNsH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231680AbiFXMLz (ORCPT + 99 others); Fri, 24 Jun 2022 08:11:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230366AbiFXMLy (ORCPT ); Fri, 24 Jun 2022 08:11:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEEB613D0F for ; Fri, 24 Jun 2022 05:11:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5648AB8286B for ; Fri, 24 Jun 2022 12:11:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC866C34114; Fri, 24 Jun 2022 12:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656072711; bh=pc8UKkAsxy+drOm1cyl5G/M+G6/DZKYcpaz2NiSvhus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WJFZhNsHRCx+tt7sQyaHgNTcYU/Bkf5NfV4m7tHwREnoX0WZWtLWu1pk0W5I81dKn g93b2w2FBjHs8svq6rMNkFrr2QhcJJergMqYOIJSy7Lp9GZPQvFumuDA666kMehpty syJJVFYU9YyV6454aIxMeom0ZXBartCRGvnMmq9/3mq8UkHdK24E61ltkyQPV1oiuv pwii1BXXhy3WCYp+AN4EBjuMrhD4Rjs6v7BPuhi36nc7d/DbhwCxTAZRSu4g1FuEcI Z06Sd65E63QVuSApVyzv9hbefV5kx03ZoaxpARCun73sy7jfQ/pMXTjOIcUBtf2yVw ojv9qcYJjxOww== Date: Fri, 24 Jun 2022 13:11:46 +0100 From: Mark Brown To: Andy Shevchenko Cc: Aidan MacDonald , Greg Kroah-Hartman , "Rafael J. Wysocki" , Matti Vaittinen , Linux Kernel Mailing List Subject: Re: [PATCH v2 01/12] regmap-irq: Convert bool bitfields to unsigned int Message-ID: References: <20220623211420.918875-1-aidanmacdonald.0x0@gmail.com> <20220623211420.918875-2-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="osEfMfwMbAxYt41i" Content-Disposition: inline In-Reply-To: X-Cookie: Help! I'm trapped in a PDP 11/70! X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --osEfMfwMbAxYt41i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 23, 2022 at 11:26:10PM +0200, Andy Shevchenko wrote: > On Thu, Jun 23, 2022 at 11:13 PM Aidan MacDonald > > Use 'unsigned int' for bitfields for consistency with most other > > kernel code. > There is no point to convert the fields you are about to remove. > So, either don't touch them or make this patch closer to the end of the series. It costs us nothing to convert them, this isn't a difficult or hard to understand refactoring - the patch is fine the way it is. --osEfMfwMbAxYt41i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmK1qgEACgkQJNaLcl1U h9DQIwf+JUtnYNjNB+6OTI9aVmigcYZIo5nLXj/pTVpyA8qZWNI2zC62X5FaXZNT KwQfbMYZ7GTc2r2P73Fl/5Lf+jdIgYGXLxQnY/ZRqm++erZuJ1fqI/a/e68CXVO8 lB/3EKX9siLMfaDtuYcH6vlN6J0ZOjoOqBQpLyW4z/hrJrn9cFUtruyGgKraax+v ZdOwahlPCCbQdeKEitkd3IoVsR5c5tNXYHU8of82McniQWeJQ3vtUjGchASv6Wvg wvVBu/q+BmxfmPzOpMeHFtTPbdWvhg1C/cQ92vpw+CEn12Jk4uZTe0Sj1zVbESAZ lxWZY6Wk/xRUJder8cLX4ag2Boxidw== =RP1q -----END PGP SIGNATURE----- --osEfMfwMbAxYt41i--