Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 20:27:53 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     K Prateek Nayak <kprateek.nayak@amd.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Mel Gorman <mgorman@suse.de>, Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Barry Song <21cnbao@gmail.com>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Len Brown <len.brown@intel.com>,
        Ben Segall <bsegall@google.com>,
        Aubrey Li <aubrey.li@intel.com>,
        Abel Wu <wuyun.abel@bytedance.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Tim Chen <tim.c.chen@intel.com>, linux-kernel@vger.kernel.org,
        Yicong Yang <yangyicong@hisilicon.com>,
        Mohini Narkhede <mohini.narkhede@intel.com>
Subject: Re: [PATCH v4] sched/fair: Introduce SIS_UTIL to search idle CPU
 based on sum of util_avg
Message-ID: <20220624122753.GA6149@chenyu5-mobl1.lan>
References: <20220612163428.849378-1-yu.c.chen@intel.com>
 <76c94a3b-6ca2-e0e2-c618-42b147d2737d@amd.com>
 <20220624020723.GA11803@chenyu5-mobl1>
 <4027cf04-d39e-d8fd-b3af-c1873757bb39@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4027cf04-d39e-d8fd-b3af-c1873757bb39@amd.com>
Precedence: bulk

On Fri, Jun 24, 2022 at 09:34:49AM +0530, K Prateek Nayak wrote:
> Hello Chenyu,
> 
> On 6/24/2022 7:37 AM, Chen Yu wrote:
> 
> >
> > [..snip..]>
> >> With v4 on the current tip, I don't see any need for
> >> a special case for systems with smaller LLCs with
> >> SIS_PROP disabled and SIS_UITL enable. Even SIS Efficiency
> >> seems to be better with SIS_UTIL for hackbench.
> >>
> >> Tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
> > Thanks again. Would you mind if I add this test report link into next patch
> > version?
> 
> Sure.
> I'm assuming the next version will disables SIS_PROP and only
> keep SIS_UTIL enabled which is the same configuration we ran
> during this round of testing. The results should stay the same :)
> --
Yes Peter has helped me change the default value of SIS_PROP and with
the current link in commit log, I assume we can find your data via it.

thanks,
Chenyu
> Thanks and Regards,
> Prateek