Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 13:56:22 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Joe Perches <joe@perches.com>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 01/12] regmap-irq: Convert bool bitfields to unsigned
 int
Message-ID: <YrW0dlXWhOo+a0sf@sirena.org.uk>
References: <20220623211420.918875-1-aidanmacdonald.0x0@gmail.com>
 <20220623211420.918875-2-aidanmacdonald.0x0@gmail.com>
 <CAHp75VfTqTfMsrdqyqRj61JAAJ4a_h3rrFriY2d+rrqpVviy=w@mail.gmail.com>
 <YrWqAqGUuy8Z0F3x@sirena.org.uk>
 <4937c0cc9dbc9d06cb626465bd37cbcf76c80a0b.camel@perches.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="s9R9sZfMsAeA9ZxE"
Content-Disposition: inline
In-Reply-To: <4937c0cc9dbc9d06cb626465bd37cbcf76c80a0b.camel@perches.com>
Precedence: bulk


--s9R9sZfMsAeA9ZxE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 24, 2022 at 05:46:10AM -0700, Joe Perches wrote:
> On Fri, 2022-06-24 at 13:11 +0100, Mark Brown wrote:
> > On Thu, Jun 23, 2022 at 11:26:10PM +0200, Andy Shevchenko wrote:

> > > There is no point to convert the fields you are about to remove.
> >=20
> > > So, either don't touch them or make this patch closer to the end of t=
he series.

> > It costs us nothing to convert them, this isn't a difficult or hard to
> > understand refactoring - the patch is fine the way it is.

> Modulo the defects that might be introduced if an overflow occurs.

This won't be an issue if the fields are removed which was what Andy was
complaining about.

--s9R9sZfMsAeA9ZxE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmK1tHUACgkQJNaLcl1U
h9AeNQf/Wi7SpXxxRgHHg80reef4GhdJlgfwJefIGf4Soq0Sj4UloPvW9AmGxCOQ
HQXa4OW03BmAX+7q9nSb9re+lpGmlWSwoZJx2JaJUrvKCWsOT/BZDx0958B3L4UR
+gCm6ktBfNk50D171mV4PRUckD65qwO+QLh15gcxFSqYq1ZmMElXdFdKhXjL29Xh
Jv6CcPrvYBqAZRc90PRD/nO5ikYobUrx9QMnRIO6KFeKMspugXk7O4ofAtOGmvv/
jaDViIxSvxV5DF0q0MK1H5R5DxtQWCzYBfG636bXvHfu6vfrf80aInRT5cmMR6Z1
3ujqMKEMiodj6RH9YELf1Ku1zVrGDA==
=Cha1
-----END PGP SIGNATURE-----

--s9R9sZfMsAeA9ZxE--