Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 16:01:28 +0300
From:   Georgi Vlaev <g-vlaev@ti.com>
To:     Nishanth Menon <nm@ti.com>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-rtc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Andrew Davis <afd@ti.com>
Subject: Re: [PATCH V4 2/2] rtc: Introduce ti-k3-rtc
Message-ID: <YrW1qLhha8VKQ5qV@jti>
References: <20220623170808.20998-1-nm@ti.com>
 <20220623170808.20998-3-nm@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220623170808.20998-3-nm@ti.com>
Precedence: bulk

Hi,

On Thu, Jun 23, 2022 at 12:08:08PM -0500, Nishanth Menon wrote:
> Introduce support for Texas Instruments Real Time Clock controller on
> newer K3 family of SoCs such as AM62x.
> 
> The hardware module that is being supported is the "digital only"
> version which doesn't have capability of external wakeup sources and
> external power backup. However, for many practical applications, this
> should suffice as RTC is operational across low power sequences.
> 
> The hardware block by itself is split into two distinct domains
> internally to further reduce the power consumption with the actual
> counter block and comparators clocked off a 32k clock source (which
> based on SoC integration can be sourced by an external crystal) and an
> register interface block which is driven by the bus clock. While optimal
> from power perspective, it does create some complicated synchronizations
> and sequences that one must be wary of in the driver handling.
> 
> Acked-by: Andrew Davis <afd@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes since V3:
> * Updates for fixing typos, removal of un-necessary prints, sharpen
>   usage of ret

Tested on SK-AM62 (AM625).

Tested-by: Georgi Vlaev <g-vlaev@ti.com>

Regards,
Georgi