Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Matthew Wilcox <willy@infradead.org>
CC:     David Hildenbrand <david@redhat.com>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "damon @ lists . linux . dev" <damon@lists.linux.dev>,
        SeongJae Park <sj@kernel.org>
Subject: Re: [PATCH v10 09/69] mm: add VMA iterator
Thread-Topic: [PATCH v10 09/69] mm: add VMA iterator
Thread-Index: AQHYhbAKusyJX2O8zEyolQwi+YlQ8q1aWzOAgALfoICAAWftgA==
Date:   Fri, 24 Jun 2022 14:31:22 +0000
Message-ID: <20220624141655.zcyebflytmftojsd@revolver>
References: <20220621204632.3370049-1-Liam.Howlett@oracle.com>
 <20220621204632.3370049-10-Liam.Howlett@oracle.com>
 <20192b57-30de-1426-6694-238e018104eb@redhat.com>
 <YrScxyQ5RRYYZFrj@casper.infradead.org>
In-Reply-To: <YrScxyQ5RRYYZFrj@casper.infradead.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zw4qK3AqAOvIsvfk+r7ixfYhN4e124ucE+uijo9Jx8518jHladfifCgrQ3dE?=
 =?us-ascii?Q?PeYRD/w7dVBa1/Ml4RmfN9iiNTSxLRgJqR5Gwg6pIbNl1O3Jif+MFfW702l4?=
 =?us-ascii?Q?t8wkjx0H0GOom7waFFQN0tWpBOm+z5B6WnvtNAEtv9q8EcIAvfQcS43CS8CI?=
 =?us-ascii?Q?0nsnnkX3QnkKn5GlBOJt0RZYZBdGkRsx8lsvdJegcJSW3oolIEp7FsK8SLn7?=
 =?us-ascii?Q?UsjoxnuQV4Wzlv2nqIgbXQyR4BfgVqrbWrV3vhhEeme9asVmY4gWnADRH2w4?=
 =?us-ascii?Q?PWms3IpSwpUgV8Zr/Vnx+5wPWdqsUZOUBlXt5pB3UGTqRUqXK5q6aEwpsRtw?=
 =?us-ascii?Q?DFjpJtikjeXfw1IRjbu0Kfnl+bRqXHW6i4L/lLInu6GEE0RLAR4ZJd/OflNJ?=
 =?us-ascii?Q?Las4wG00kEtE0MO6erDMvXEbt5TzcaMVys/UVTpj6Z/qBvQWpih2qoQTnQfF?=
 =?us-ascii?Q?/sqlxaZ/3lSMiPHxkLEqfY7KKM8qPYTy8z2ysPLkpyMm864yMNjWzMpYdSZM?=
 =?us-ascii?Q?AzkxlzkOXh0IQqCR2JViwI+AwWZz4Kxm3FNkLISukSPd/PYoRYoSx1POyvPI?=
 =?us-ascii?Q?eZsA/P6hNVYbYG1b2dnpX3MTLKsZVMR5sQPgJr20o7EAu9yJ58IKXnUVoMQt?=
 =?us-ascii?Q?ws9seyT1BZq57p/QqZOklB0u4mbCuEd9f8WSRSrSqTQMqCUNQrxg9nyE5Nut?=
 =?us-ascii?Q?pmAZqWw5wsEmMu8cJumvYccLfXEnoBOLNAKOlyfDfcOhrBYvP9sYDb2Skk8K?=
 =?us-ascii?Q?s4cp/bDhf+4152V/lr7OYX2+kWAIvWgcdgpByvJeIiLnySqpZ5PMrBfPN83Q?=
 =?us-ascii?Q?o9/e/3fJNquBkE66uMm10PoIQOtm9NgCNy6yt/aKZRLWzplPn47PrVCVo9fS?=
 =?us-ascii?Q?V5OfNI6hOd+zeSAyMnrXpJ9MpqKF7eHeOswsmXmLwtHEDSLcU6SikTGWyenI?=
 =?us-ascii?Q?Y/+6nNSPT/Y9DG0PLJ73Ty8fKIqL8b6eBO+YRCZT/GCskj65zaVIlI/db2nd?=
 =?us-ascii?Q?iBBQHZlf40xRIP/SeaEkscD5ihOeR7hD3DNZ49QfWZ2t6liBHpEHPHuc1Kdc?=
 =?us-ascii?Q?x/WlF/9Fq37Or3GW0+sF65BNTYD7KAnVWD3GoV+vF0fTCP50ScFSlmRVYtd6?=
 =?us-ascii?Q?J0DlAHOV+IgFCgYb8LQWmWXQwEUS8IX5cR1i00EL8nUC/fq4+0G+5Cf/Bbs5?=
 =?us-ascii?Q?Jmx9/U3geUTNg+5AmxLczlEERLCP9tcbNmikMgGoXp8py7LzvhB93ONFkyeg?=
 =?us-ascii?Q?r5JFyb2b5nTPfdPE17jx3YB+yY6GhVjTKMdhugim6gyEwh1yk0KoCAuKPfEX?=
 =?us-ascii?Q?atCvJhfGGa3HKKrFh0PQZczG7AXGYmYYamJg4UA7wNsqlLrn8U2hO6025dMs?=
 =?us-ascii?Q?aQS61eqdzUTr1ueBFiSRI5iYnbGlIu+fAOB56YXn7bqoO8UejYCUDsGprlDd?=
 =?us-ascii?Q?DfNqFJ83z/o3aimShN4Z55bmFstlHC5mxSf5GnuGesNrFOB7LXMc5z6tz3Xl?=
 =?us-ascii?Q?vfbNFV25h0UPluQCNrHfNa/LSYYGsBRiJa//M92O7MKPaL3u4J5GRNW0ilAz?=
 =?us-ascii?Q?ont4r7Ysk7ePs5rcc9EcaTW4P7BepMvVm0ns0l82js0zs4RNZv8b63+p4Mo3?=
 =?us-ascii?Q?oA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7E8EDAF540AFD34791C24BA831E94333@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cea0bfa-ccf1-4470-ed6a-08da55ee362b
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2022 14:31:22.5459
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oH2Gf8a2Tu/pHvPj76YUgcrDmMFlc/FOJUnGRrYNtFxkQJ9SHKHYr9xtKPOBt0lhSamHKarzIwvjR8Aw9OhJ1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3107
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-24_07:2022-06-23,2022-06-24 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0
 phishscore=0 adultscore=0 suspectscore=0 mlxlogscore=589 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206240056
X-Proofpoint-GUID: -7f6ZS_e1cqc0kym1wBcmoZWk9acaONg
X-Proofpoint-ORIG-GUID: -7f6ZS_e1cqc0kym1wBcmoZWk9acaONg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Matthew Wilcox <willy@infradead.org> [220623 13:03]:
> On Tue, Jun 21, 2022 at 11:10:09PM +0200, David Hildenbrand wrote:
> > > +#define VMA_ITERATOR(name, mm, addr) 					\
> > > +	struct vma_iterator name =3D {					\
> > > +		.mas =3D {						\
> > > +			.tree =3D &mm->mm_mt,				\
> > > +			.index =3D addr,					\
> > > +			.node =3D MAS_START,				\
> > > +		},							\
> > > +	}
> > > +
> >=20
> > No __* and () macro magic?
> >=20
> > I'd have expected at least
> >=20
> > tree =3D &(__mm)->mm_mt,
> > .index =3D (__addr),
> >=20
> > ;)
>=20
> Fair, fair.  Just testing that change now.  I always forget to do those
> things until they bite me.
>=20
> > Reviewed-by: David Hildenbrand <david@redhat.com>
>=20
> Appreciate the review!


I'll also do the same underscores for the maple tree defines where
necessary.

Thanks David.

>=20
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index acbd8d03e01e..8bcbffefdc02 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -686,11 +686,11 @@ struct vma_iterator {
>  	struct ma_state mas;
>  };
> =20
> -#define VMA_ITERATOR(name, mm, addr) 					\
> +#define VMA_ITERATOR(name, _mm, _addr)	 				\
>  	struct vma_iterator name =3D {					\
>  		.mas =3D {						\
> -			.tree =3D &mm->mm_mt,				\
> -			.index =3D addr,					\
> +			.tree =3D &(_mm)->mm_mt,				\
> +			.index =3D (_addr),				\
>  			.node =3D MAS_START,				\
>  		},							\
>  	}=