Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp476889iog; Fri, 24 Jun 2022 07:41:21 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tjxVpGlrFV/sOZvRKOoXdUDM3LIpwTR63wt9ro85rDfS9TcPIBp0YmN3wKWDBBxNtNM3bA X-Received: by 2002:aa7:de1a:0:b0:435:7d11:9717 with SMTP id h26-20020aa7de1a000000b004357d119717mr18034770edv.148.1656081681120; Fri, 24 Jun 2022 07:41:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656081681; cv=none; d=google.com; s=arc-20160816; b=s/s7Z8XEXnVPjKXdUjKBk0X1A5Bvt4SHnt7bxlVFSmJ7rm3JDWqRAGgfxGnsQzdD0H MTsgVWx6Bb1NDJGSSrT7Hg2n4fg/udW2kZwl4V4gztmSlezUtpCb/TMXt9u1VKxUV1/J ikS0mdplll7lVFUmGs3DEQXGplWykTxx+tp/4dCB+H0b7bLUJCgKiQL9ITDsV8VPKgUs C2xwwAj440d1Qgrz0eKkFf/dwvpCwF5BoXmpVVsxds3ZzZah8CyAb//iKM+hcbjZVWiM j2dkd83/ekZSOEBhnHEWVxEJGX3A0dWoQ9ATjNiC9F/EQ4YuwDt44XicbcKW7ffQiWBx VOPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=fjqF7NWw/FCmgG6xr4gRWQxyr+5s3ucRtCSkydMD9C4=; b=0oiOA9DqPc8S1ZM7Y+X5bj87djtTLx4+h7sle+iYykD1Va8nOLXgkyN3h+8kjaxvXe a5Tw6ijt1O5M+jHvuvtFru0npgiqoJ+h3xEd9iKDkfH+HEBCzx7yih6ajMglqXf1xMip 6plBcUuazKUpQUUlSDTVHaFCkMiQyrgzEaS1aPy8c6gEpVOlnvikJDcjyzMg6HBEVw4h o/DdeaTMhHItdbSeya3Gm2tSIJi/aqp2lfU5tLxUVckwTLv1Itpy6wWpijVaF6+r/Ds/ H5Ser49yZSZqeraLgaLnO1cePBObToVWPzuqWzDaJt+1nnKUpkdONkOLBoXK/cppnAFa BCcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hsmdt5LT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j26-20020a1709062a1a00b006e86e8d7520si2701883eje.186.2022.06.24.07.40.56; Fri, 24 Jun 2022 07:41:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hsmdt5LT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232999AbiFXOhU (ORCPT + 99 others); Fri, 24 Jun 2022 10:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232841AbiFXOgm (ORCPT ); Fri, 24 Jun 2022 10:36:42 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FB3056C07 for ; Fri, 24 Jun 2022 07:35:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5CCAEB82925 for ; Fri, 24 Jun 2022 14:35:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 646D3C341C0; Fri, 24 Jun 2022 14:35:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656081347; bh=fES71k0ZtQMfRPu9DCT9ZOVYdQvNBjl3fNHC6w3pSEc=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=Hsmdt5LTyq7cqedpM7gD3mcbjTqTZVbXcWKBNDxL/nyNXh7QuMwjQ7X3ZkyQfEMS5 Kdh+uekKRjxFdw0vb9b8c6lwbHpQqddsFR4oHiVYwa5BNCUy3eHchli72h2SDIuN41 eWKSgqEpPHVxgOfnphX4wAtuA0nksQX4p+f8jQbXuc8w9G32PNwcLP4/fB62l3+jqw H0LDGLFIFqEz8Kb63K/UqL4SxCQ3FOJjUFbQiuYnFn8KnA0LwJ/rtjmUCDKd0108Hy cAyth5zSs6zw/PuBediVxP+YxqQUm/7CT5eQ6Td9KeKJ1juFc97abm97Yy0gvZjprA ZtYgphvV7oKDg== From: Mark Brown To: jiapeng.chong@linux.alibaba.com, lgirdwood@gmail.com Cc: alsa-devel@alsa-project.org, tiwai@suse.com, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, perex@perex.cz In-Reply-To: <20220624082745.68367-1-jiapeng.chong@linux.alibaba.com> References: <20220624082745.68367-1-jiapeng.chong@linux.alibaba.com> Subject: Re: [PATCH] ASoC: rockchip: i2s: Fix missing error code in rockchip_i2s_probe() Message-Id: <165608134513.445804.8165290048747586515.b4-ty@kernel.org> Date: Fri, 24 Jun 2022 15:35:45 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jun 2022 16:27:45 +0800, Jiapeng Chong wrote: > The error code is missing in this code scenario, add the error code > '-EINVAL' to the return value 'ret'. > > This was found by coccicheck: > > sound/soc/rockchip/rockchip_i2s.c:810 rockchip_i2s_probe() warn: missing error code 'ret'. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: rockchip: i2s: Fix missing error code in rockchip_i2s_probe() commit: 7f6409fd9b54b6f56444edc996cd28059f215415 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark