Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 16:35:25 +0200
From:   Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Maxime Ripard <mripard@kernel.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm: logicvc: Fix uninitialized variable in probe
Message-ID: <YrXLrVUIavGWC4sx@aptenodytes>
References: <Yqh6OfSiPFuVrGo4@kili>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="DwiraIsIEPc2Ikp+"
Content-Disposition: inline
In-Reply-To: <Yqh6OfSiPFuVrGo4@kili>
Precedence: bulk


--DwiraIsIEPc2Ikp+
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Dan,

On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> The "regmap" is supposed to be initialized to NULL but it's used
> without being initialized.
>=20
> Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller=
")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Nice catch, thanks a lot!

Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> ---
>  drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logi=
cvc/logicvc_drm.c
> index df1805cf0f95..0b983a33f9ff 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_drm.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
> @@ -298,7 +298,7 @@ static int logicvc_drm_probe(struct platform_device *=
pdev)
>  	struct logicvc_drm *logicvc;
>  	struct device *dev =3D &pdev->dev;
>  	struct drm_device *drm_dev;
> -	struct regmap *regmap;
> +	struct regmap *regmap =3D NULL;
>  	struct resource res;
>  	void __iomem *base;
>  	int irq;
> --=20
> 2.35.1
>=20

--=20
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

--DwiraIsIEPc2Ikp+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK1y60ACgkQ3cLmz3+f
v9F7Kwf/QJpFMndulFNyA2x3mb7KHVGg3dQKG+3a7CvlFT2m+N0OUW6HcXSkmz+x
Z7Ccffbm4Lb2E+gQucPwwPDReZieX4IrVhiHQfoc5IRTq5916CRouPxGGmzzq5KS
pUYjhWq9PNNNU+oDiZ6k04H2ozX8T8fABH7/U2ZBeRZ0oocBXMZL2hXnvNbLou4C
1dPE5D/rMZ7qGKkFi7Oks5c1IWz3Sx9ieku6ZH+AGbq7yr5ILxt5zfIuEH02NPZ9
DpaVENSmpOccaOZcM00rIbUFwVpLptmV56Woar15J9NZBcgewR2j655GQk/M1jG9
hMSQofNJAMMQRLPA3S7vgd8+lnQTrA==
=Ojhr
-----END PGP SIGNATURE-----

--DwiraIsIEPc2Ikp+--