Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 17:26:21 +0200
From:   Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] drm: Remove unnecessary print function dev_err()
Message-ID: <YrXXnfFLrYFXInvJ@aptenodytes>
References: <20220613012658.85814-1-yang.lee@linux.alibaba.com>
 <YrXRplhnlUZ2KV3V@aptenodytes>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="j1BiNMI1wuOdzFcL"
Content-Disposition: inline
In-Reply-To: <YrXRplhnlUZ2KV3V@aptenodytes>
Precedence: bulk


--j1BiNMI1wuOdzFcL
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri 24 Jun 22, 17:00, Paul Kocialkowski wrote:
> Hi Yang,
>=20
> On Mon 13 Jun 22, 09:26, Yang Li wrote:
> > The print function dev_err() is redundant because platform_get_irq()
> > already prints an error.
> >=20
> > Eliminate the follow coccicheck warning:
> > ./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant
> > because platform_get_irq() already prints an error
> >=20
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>=20
> Thanks for the patch!
>=20
> Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Pushed to drm-misc-next, thanks!

Paul

> > ---
> >  drivers/gpu/drm/logicvc/logicvc_drm.c | 1 -
> >  1 file changed, 1 deletion(-)
> >=20
> > diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/lo=
gicvc/logicvc_drm.c
> > index df1805cf0f95..437b3011ae1e 100644
> > --- a/drivers/gpu/drm/logicvc/logicvc_drm.c
> > +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
> > @@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device=
 *pdev)
> > =20
> >  	irq =3D platform_get_irq(pdev, 0);
> >  	if (irq < 0) {
> > -		dev_err(dev, "Failed to get IRQ\n");
> >  		ret =3D -ENODEV;
> >  		goto error_reserved_mem;
> >  	}
> > --=20
> > 2.20.1.7.g153144c
> >=20
>=20
> --=20
> Paul Kocialkowski, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com


--=20
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

--j1BiNMI1wuOdzFcL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEyBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK1150ACgkQ3cLmz3+f
v9FYQQf3XfVBAjvqS/RDgAVJLtAli6neGvkwnOPb6qRfD97qH1SAUsOHmE0arjmr
gRLKR9SPSTTf+1w78Uyp8su3XXvlOqJ/axvc2ZnrHdrPan0Bwa3vRI60mlQPtI+a
7JedVfCH5c2vXyHnO+vKYNI7s1kZYj+pbHMU6jKqlYNE8VHlarWtwVzsEVNBNab5
Ykn2juFT5BDr3PLlp3bYOpYl1SPuBCgHpTjgK+w98crusO080x79niQ71WOdWlt2
iaRf1cTQbmo2m9tNV3w0e2hKSDbZa5gjeUqeC8fJubR3pKj7p36YsU8sYnK6PCkD
BHOGlJl3S3Y+i4qLnNOG6GMDd6kX
=OYMV
-----END PGP SIGNATURE-----

--j1BiNMI1wuOdzFcL--