Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac726845-01ec-4f35-7197-4c52fc483644@linaro.org>
Date:   Fri, 24 Jun 2022 18:01:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] ASoC: dt-bindings: fsl,micfil: Convert format to
 json-schema
Content-Language: en-US
To:     Shengjiu Wang <shengjiu.wang@nxp.com>, lgirdwood@gmail.com,
        broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     shengjiu.wang@gmail.com
References: <1655980125-24141-1-git-send-email-shengjiu.wang@nxp.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <1655980125-24141-1-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/06/2022 12:28, Shengjiu Wang wrote:
> Convert the NXP MICFIL binding to DT schema format using json-schema.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  .../devicetree/bindings/sound/fsl,micfil.txt  | 33 ---------
>  .../devicetree/bindings/sound/fsl,micfil.yaml | 73 +++++++++++++++++++
>  2 files changed, 73 insertions(+), 33 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/fsl,micfil.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl,micfil.txt b/Documentation/devicetree/bindings/sound/fsl,micfil.txt
> deleted file mode 100644
> index 1ea05d4996c7..000000000000
> --- a/Documentation/devicetree/bindings/sound/fsl,micfil.txt
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -NXP MICFIL Digital Audio Interface (MICFIL).
> -
> -The MICFIL digital interface provides a 16-bit audio signal from a PDM
> -microphone bitstream in a configurable output sampling rate.
> -
> -Required properties:
> -
> -  - compatible		: Compatible list, contains "fsl,imx8mm-micfil"
> -			  or "fsl,imx8mp-micfil"
> -
> -  - reg			: Offset and length of the register set for the device.
> -
> -  - interrupts		: Contains the micfil interrupts.
> -
> -  - clocks		: Must contain an entry for each entry in clock-names.
> -
> -  - clock-names		: Must include the "ipg_clk" for register access and
> -			  "ipg_clk_app" for internal micfil clock.
> -
> -  - dmas		: Generic dma devicetree binding as described in
> -			  Documentation/devicetree/bindings/dma/dma.txt.
> -
> -Example:
> -micfil: micfil@30080000 {
> -	compatible = "fsl,imx8mm-micfil";
> -	reg = <0x0 0x30080000 0x0 0x10000>;
> -	interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> -		     <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
> -	clocks = <&clk IMX8MM_CLK_PDM_IPG>,
> -		 <&clk IMX8MM_CLK_PDM_ROOT>;
> -	clock-names = "ipg_clk", "ipg_clk_app";
> -	dmas = <&sdma2 24 26 0x80000000>;
> -};
> diff --git a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> new file mode 100644
> index 000000000000..74c77f4cf7a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/fsl,micfil.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP MICFIL Digital Audio Interface (MICFIL)
> +
> +maintainers:
> +  - Shengjiu Wang <shengjiu.wang@nxp.com>
> +
> +description: |
> +  The MICFIL digital interface provides a 16-bit or 24-bit audio signal
> +  from a PDM microphone bitstream in a configurable output sampling rate.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - fsl,imx8mm-micfil
> +      - fsl,imx8mp-micfil
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 4

You should describe the interrupts/items. Similarly to clocks.

Best regards,
Krzysztof