Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764841AbXEYTme (ORCPT ); Fri, 25 May 2007 15:42:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753337AbXEYTm2 (ORCPT ); Fri, 25 May 2007 15:42:28 -0400 Received: from 2.0-25.235.16.216.in-addr.arpa ([216.16.235.2]:47815 "EHLO rubicon.netdirect.ca" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753324AbXEYTm1 (ORCPT ); Fri, 25 May 2007 15:42:27 -0400 X-Originating-Ip: 72.143.65.211 Date: Fri, 25 May 2007 15:40:18 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Satyam Sharma cc: Krzysztof Halasa , Adrian Bunk , Linux Kernel Mailing List Subject: Re: any value to "NORET_TYPE" macro? In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-16.8, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00, RCVD_IN_SORBS_DUL 20.00) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1845 Lines: 42 On Sat, 26 May 2007, Satyam Sharma wrote: > Hi Robert, > > On 5/25/07, Robert P. J. Day wrote: > > On Fri, 25 May 2007, Satyam Sharma wrote: > > ... > > > 1. If this is a function _declaration_ (i.e. a prototype in some > > > header or some .c file), then remove the NORET_TYPE macro. Also, > > > if an ATTRIB_NORET or NORET_AND already exists then you're done. > > > Else, introduce an ATTRIB_NORET after the arglist but before ; > > > > actually, what i would be introducing in all cases is "__noreturn", > > the short form currently defined in compiler-gcc.h. and i would be > > removing every instance of ATTRIB_NORET and its buddies. > > Ummm ... you mean we're replacing all occurrences of ATTRIB_NORET > as well? Note that NORET_TYPE and ATTRIB_NORET are both defined > in the generic include/linux/linkage.h whereas __noreturn is in > compiler-gcc.h which is included only for gcc builds -- hence, my > preference for ATTRIB_NORET. Also, there is not even a single user of > __noreturn anywhere in the kernel code whereas ATTRIB_NORET is used > in all these places, which means it looks like to be the standard thing ... > Anyway, I'm fine either way. ah, i hadn't noticed that. i must think on this more. man, i thought this was going to be so simple. argh. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/