Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   alexandre.belloni@bootlin.com
To:     linux-kernel@vger.kernel.org, mat.jonczyk@o2.pl,
        linux-rtc@vger.kernel.org
Cc:     Alexandre Belloni <alexandre.belloni@bootlin.com>, bp@alien8.de,
        hpa@zytor.com, x86@kernel.org, dave.hansen@linux.intel.com,
        a.zummo@towertech.it, tglx@linutronix.de, mingo@redhat.com
Subject: Re: (subset) [PATCH 1/3] rtc-mc146818-lib: reduce RTC_UIP polling period
Date:   Fri, 24 Jun 2022 18:45:11 +0200
Message-Id: <165608905386.24026.1966178825029089110.b4-ty@bootlin.com>
In-Reply-To: <20220225215011.861477-2-mat.jonczyk@o2.pl>
References: <20220225215011.861477-1-mat.jonczyk@o2.pl> <20220225215011.861477-2-mat.jonczyk@o2.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

From: Alexandre Belloni <alexandre.belloni@bootlin.com>

On Fri, 25 Feb 2022 22:50:09 +0100, Mateusz Jończyk wrote:
> Waiting 1ms every time is not necessary, for example on some AMD boxes
> the RTC_UIP bit is documented as being high for around 270 microseconds
> in some cases [1], which agreed with experiments on an SB710
> southbridge. So 100us seems optimal.
> 
> This in preparation for mach_get_cmos_time() refactoring.
> The functions mc146818_get_time() and mach_get_cmos_time() in
> arch/x86/kernel/rtc.c perform the same function and the code is
> duplicated. mach_get_cmos_time() is busy waiting for the RTC_UIP
> bit to clear, so make mc146818_get_time() more similar to it by reducing
> the polling period.
> 
> [...]

Applied, thanks!

[1/3] rtc-mc146818-lib: reduce RTC_UIP polling period
      commit: 4b94a798e1ca59f4614f5ff6b94fe0c287412b9b

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>