Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp624893iog; Fri, 24 Jun 2022 10:26:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tQibnonMR9/UuX5h3wwOgTr59cV223CBpUTjKTHnOUFpcOWGArPeGSl8veaPvq3zMQaDWA X-Received: by 2002:a17:907:9805:b0:711:dc46:e0fe with SMTP id ji5-20020a170907980500b00711dc46e0femr48164ejc.179.1656091599547; Fri, 24 Jun 2022 10:26:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656091599; cv=none; d=google.com; s=arc-20160816; b=HXqVtQH/oOrRTDzut4YKipQaS7kPQEkUfabu0Zsf7hHmh6iXb8uycovj/WJ/ieIR15 vx74y4/vVJerMbP4q+5JcSpgTd+8sjJma1K0f2UTNlesMesKxUJTfCWcYL35UnzcSEgH UkSLmLsvW78MdO9iKsMwE/ZNr15PPOeT0OMd+s5cfqvSW/Aq6gOMxO6oUiWpD3RXEutU TeiQAzUDDy0CuvU7e9a2FbhLVzadQpLmkfjbc0nRewIAwkPeg6z2FfokZ5Ks1bqLLY+X 9V7ka59YT5rlAaFMptGqLpt5vOG8GGaObEdV1pDROYsW5oH/OGZOFqSWHX9rDJ3p6uNT YmmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Vu75/Qb+i/F4hmojAa19FfVuxCVN3Y8Kms3HlIXz4Bw=; b=WT+xgUrtIb0n2AkOnvfrHkOoTiSp4JL9H6le9DLUI0x7VNCsNQdVZO27qEwG32Tz0q LsC5tVrZxp3FrB/NTnV+vrdR+T2MtEeUtjzP0SxNNIiG5Jfo/7XWkNVYP/NFs7BovNdk pj9ehjKEeoGAFQpEfLDD/v36Rf46BKSDqG6GIITei3Pi5a9ws9iLBghq9JH7G7ZE8QLp jkB9Zm7gmfozjPuHHfzKQKHidChwbuy0dNUvUdCQV/78S+UcF7AnhvhLIyFOrqte82gZ eAcaEirq1/MeADnrbZaBPSZRFrBDA2f7sfktQ2G8UM6dm+eNprqgPVXPadoXdPS9LZ06 l30g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=EPrBT8fG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds21-20020a170907725500b006feb3a01b16si3521827ejc.683.2022.06.24.10.26.12; Fri, 24 Jun 2022 10:26:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=EPrBT8fG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231732AbiFXRJI (ORCPT + 99 others); Fri, 24 Jun 2022 13:09:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231772AbiFXRJC (ORCPT ); Fri, 24 Jun 2022 13:09:02 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFB4B51E7E; Fri, 24 Jun 2022 10:09:01 -0700 (PDT) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id BBE9DE0005; Fri, 24 Jun 2022 17:08:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656090540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vu75/Qb+i/F4hmojAa19FfVuxCVN3Y8Kms3HlIXz4Bw=; b=EPrBT8fGVuNJl/TAirSVa37usMnguJ0f1Y0xCAG/d96OU78UCw5V15KNdh1kTrqTzhmwRM 5KkxbWDqBAC262Hmr4xvEWBpm1YlY2uOsVyvSJv2IJL6Bwnzmtm5afkDZF+jTO0ACeyaSv 1d+WlMjNucOXDEg/loZSQZuHMEZlQ370ElPpojW0jgN3qSAbLz7NN1TMlBJTF459MWJfI1 fl1yBlNFto30n88gyTf49IaFemdXouxYWDlvx9j9jAoadjyPmQX9eDyUX7isx8z6x3f2xn TDD8+4W7iAjcja+49M1ktfCke0ltcy/7sPw5AB+Hmjo3PtzcS4FLDfQ5Hks4Ig== Date: Fri, 24 Jun 2022 19:08:58 +0200 From: Alexandre Belloni To: foss+kernel@0leil.net Cc: linux-rtc@vger.kernel.org, quentin.schulz@theobroma-systems.com, linux-kernel@vger.kernel.org, a.zummo@towertech.it Subject: Re: [PATCH] rtc: isl1208: do not advertise update interrupt feature if no interrupt specified Message-ID: <165609051724.27429.18295826165750824603.b4-ty@bootlin.com> References: <20220523145320.123713-1-foss+kernel@0leil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220523145320.123713-1-foss+kernel@0leil.net> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 May 2022 16:53:20 +0200, Quentin Schulz wrote: > From: Quentin Schulz > > If an ISL1208 device does not have an interrupt line routed, the feature > shouldn't be advertised (it is by default in rtc core) or it'll confuse > userspace requesting that feature (such as hwclock from util-linux). > > > [...] Applied, thanks! [1/1] rtc: isl1208: do not advertise update interrupt feature if no interrupt specified commit: ddc9c54b6b993bca4aa810402b17a0f42c5744d1 Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com