Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 11:04:07 -0600
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] rpmsg: Fix parameter naming for announce_create/destroy
 ops.
Message-ID: <20220624170407.GB1736477@p14s>
References: <20220425071723.774050-1-arnaud.pouliquen@foss.st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220425071723.774050-1-arnaud.pouliquen@foss.st.com>
Precedence: bulk

On Mon, Apr 25, 2022 at 09:17:23AM +0200, Arnaud Pouliquen wrote:
> The parameter associated to the announce_create and
> announce_destroy ops functions is not an endpoint but a rpmsg device.
> 
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
> ---
> No fixed sha1 indicated in commit message as issue is present since a
> while, it does not fix a specific sha1.
> 
> git blame highlight the sha1 [1], but issue was present before.
> The commit [1] just moves declaration from rpmsg.h to rpmsg_internal.
> 
> [1] fade037e0fd5 ("rpmsg: Hide rpmsg indirection tables")

This patch is not a candidate for the stable kernel and as such a "Fixes" tag
isn't needed.

> ---
>  drivers/rpmsg/rpmsg_internal.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h
> index d4b23fd019a8..ff0b12122235 100644
> --- a/drivers/rpmsg/rpmsg_internal.h
> +++ b/drivers/rpmsg/rpmsg_internal.h
> @@ -41,8 +41,8 @@ struct rpmsg_device_ops {
>  					    rpmsg_rx_cb_t cb, void *priv,
>  					    struct rpmsg_channel_info chinfo);
>  
> -	int (*announce_create)(struct rpmsg_device *ept);
> -	int (*announce_destroy)(struct rpmsg_device *ept);
> +	int (*announce_create)(struct rpmsg_device *rpdev);
> +	int (*announce_destroy)(struct rpmsg_device *rpdev);

I have applied this patch.

Thanks,
Mathieu

>  };
>  
>  /**
> -- 
> 2.24.3
>