Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp630620iog; Fri, 24 Jun 2022 10:32:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vx0fZ/cG67GOj8o5295sTLscCz0iAZ3YbTexxnkawWwdXiyOSUGz1prF0+PWbvFEKKdhIs X-Received: by 2002:a17:907:30cb:b0:722:e898:c9c8 with SMTP id vl11-20020a17090730cb00b00722e898c9c8mr61476ejb.465.1656091973589; Fri, 24 Jun 2022 10:32:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656091973; cv=none; d=google.com; s=arc-20160816; b=CtdpwyQXd1AIhiBcgxgrk+9hW2eMmhmktWrJ3e4HKa5n4DinccCo5TCNsodCIrvXn9 +pLFKJtQKPDoI1PFA/tR2mwfhquzd302EngFQJ6l9+rW9+311E/73gmgKuk7N1HTaMYI nq9KXrSCu8xN48pJ3KwpygZiVTNk0RLP35yxfXq4owtKnBmvzB6SiGIcr2a6ysAG3+by LQ+KF6cMHftFQBuLvU900qBPZnijM4iRfGtNHbF/NMURPGTCmA7MTiqx3BRSUvWwkFV/ MBj/Lv7d7qptLMG5zG4s2rwgvdCJb3jEMuXjDNSNPV793jpfM6hqUuHGU+5pEyWvXLHn VmDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=YImQrOCjpI1Pf4sniYSIQE78QxCL87Zrr2ZodYXVNnY=; b=gbLM0avq3QRSqPSqieTq2l3LN9xF5lV0HwmDmQ+2DYHz1yJ/JlQ8aNND/Gsc8zLVwX 3bJJeLIIQ6+h1tXalqvz0rP+aJnNGq3F80xbBv8uQr/tYp9H+OJAVghgXux1wqRoPmkW 5XpNvN8ZOuKu1KiqalEOlufJFvKU7uhQXshgibshJLa4Zrfk8///Fsd8vAPLm7+jSyoo TM1WMAcgW2TxrL8q7seI4KsHSlCHPaAfWzwONu8lHYA0lxo5ZiMPMPEkAh5MYmxry+d8 XR+M9jBIn6+tKNdjr4d0ThMGfsXgzO4dPS34y8Kcv6Ap9ekK/id4uGanCod4hH+h0Znb zq/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa1 header.b="fWqRVZB/"; dkim=neutral (no key) header.i=@ravnborg.org header.s=ed1 header.b=0aamlKax; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd39-20020a1709076e2700b00722e82edf26si3454189ejc.968.2022.06.24.10.32.16; Fri, 24 Jun 2022 10:32:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa1 header.b="fWqRVZB/"; dkim=neutral (no key) header.i=@ravnborg.org header.s=ed1 header.b=0aamlKax; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230334AbiFXR0s (ORCPT + 99 others); Fri, 24 Jun 2022 13:26:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232438AbiFXR01 (ORCPT ); Fri, 24 Jun 2022 13:26:27 -0400 Received: from mailrelay2-1.pub.mailoutpod1-cph3.one.com (mailrelay2-1.pub.mailoutpod1-cph3.one.com [46.30.210.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D34315816 for ; Fri, 24 Jun 2022 10:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=YImQrOCjpI1Pf4sniYSIQE78QxCL87Zrr2ZodYXVNnY=; b=fWqRVZB/Piz7vR6GT/pFrKYPjNsODm6Lt5B5pbB2athdA4enwZe3cwndBcrnJ57M6ATcujp0kKW2S F6fM7giyCy9Eh1wtt9/qJRhGx2q7M8tLUenHtxp2qOh/9dtEarCJJcJCpYgFrHU3kLAUqx6xlAk2hW 70PpcGcRobBymntLPaACuMV0fd5rBXAsNsmR3OMe5ki6m1TsvkwaAPK8HgZfdjLmdpC6brj1laBfET IqcPFOkzGb1JR0K7XH4FVH5btEvWwMgBg2tNiNr8kWwTgCqfciZjWE6pHIncd9tFNOaIoAD22KMoN+ RfT6/ejTF77vupkcDkBHddZGHkF8W7w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=YImQrOCjpI1Pf4sniYSIQE78QxCL87Zrr2ZodYXVNnY=; b=0aamlKaxWOlroxmiYOuL5/s5MGru3Ba31/MhPmFhmYdTmN8Rn2J7h0+f9Zgt2oxQkHzfCsZIhEUVg 8SIHF1ECA== X-HalOne-Cookie: 96a8abf5ab4b9e66dba2a4c7a0ea66e15d8eb3a2 X-HalOne-ID: 9728a25b-f3e2-11ec-a916-d0431ea8a290 Received: from mailproxy4.cst.dirpod4-cph3.one.com (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) by mailrelay2.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 9728a25b-f3e2-11ec-a916-d0431ea8a290; Fri, 24 Jun 2022 17:25:06 +0000 (UTC) Date: Fri, 24 Jun 2022 19:25:05 +0200 From: Sam Ravnborg To: Jiapeng Chong Cc: paul@crapouillou.net, airlied@linux.ie, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/ingenic: Use resource_size function on resource object Message-ID: References: <20220624013159.88646-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220624013159.88646-1-jiapeng.chong@linux.alibaba.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiapeng, On Fri, Jun 24, 2022 at 09:31:59AM +0800, Jiapeng Chong wrote: > This was found by coccicheck: > > ./drivers/gpu/drm/ingenic/ingenic-drm-drv.c:1149:35-38: WARNING: Suspicious code. resource_size is maybe missing with res. > Nice one, now I have to go back and fix my code as well. > Signed-off-by: Jiapeng Chong Reviewed-by: Sam Ravnborg