Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 10:30:23 -0700
From:   Kees Cook <keescook@chromium.org>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Peter Jones <pjones@redhat.com>, Jeremy Kerr <jk@ozlabs.org>,
        Tony Luck <tony.luck@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v3 1/9] pstore: Add priv field to pstore_record for
 backend specific use
Message-ID: <202206241029.9C0891C5B6@keescook>
References: <20220624084925.724516-1-ardb@kernel.org>
 <20220624084925.724516-2-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220624084925.724516-2-ardb@kernel.org>
Precedence: bulk

On Fri, Jun 24, 2022 at 10:49:17AM +0200, Ard Biesheuvel wrote:
> The EFI pstore backend will need to store per-record variable name data
> when we switch away from the efivars layer. Add a priv field to struct
> pstore_record, and document it as holding a backend specific pointer
> that is assumed to be a kmalloc()d buffer, and will be kfree()d when the
> entire record is freed.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

I'm a fan! This is useful, and I'll likely try to use it for some of the
RAM-specific things too. :)

Acked-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook