Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 17:38:21 +0000
From:   David Matlack <dmatlack@google.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] KVM: x86/mmu: Use "unsigned int", not "u32", for
 SPTEs' @access info
Message-ID: <YrX2ja1r1/7LGv+k@google.com>
References: <20220624171808.2845941-1-seanjc@google.com>
 <20220624171808.2845941-3-seanjc@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220624171808.2845941-3-seanjc@google.com>
Precedence: bulk

On Fri, Jun 24, 2022 at 05:18:07PM +0000, Sean Christopherson wrote:
> Use an "unsigned int" for @access parameters instead of a "u32", mostly
> to be consistent throughout KVM, but also because "u32" is misleading.
> @access can actually squeeze into a u8, i.e. doesn't need 32 bits, but is
> as an "unsigned int" because sp->role.access is an unsigned int.
> 
> No functional change intended.
> 
> Link: https://lore.kernel.org/all/YqyZxEfxXLsHGoZ%2F@google.com
> Cc: David Matlack <dmatlack@google.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: David Matlack <dmatlack@google.com>