Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp656330iog; Fri, 24 Jun 2022 11:04:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v+QZA70/KqBQv3BUm/J/kRr86r4m3sVPNYe455UCv/sBiUf93dk4zcSLktM1IrLUnOyC97 X-Received: by 2002:a05:6a00:1a91:b0:51c:2ef4:fa1c with SMTP id e17-20020a056a001a9100b0051c2ef4fa1cmr345158pfv.75.1656093897827; Fri, 24 Jun 2022 11:04:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656093897; cv=none; d=google.com; s=arc-20160816; b=y9WMzLMVB9Dvx3aU/aEEAM/oQTghu9kBPPDcZ/TPDVyEvQzIYaDnqcAfLxwc+oTBbz 9SP1mzWBtfLZLaEXdnVC//GSQARKcpfSRvKl7lODrj7q7AmrRlQYpYKYyyNG91Q2I9rZ MW2tTN/pvVGOsxXDZCWYMQ/pWfJj9UKyIKOwM2oC38a1EF7KFTJjeKdMtG95UlHzGYjI XqJUXmJT/3kEzlCiuSmyi4/KxAiHgnNx2ERhOCUiGAnFmGrlH26FxxlEs01+jYToeQ2I wcE0zYSWlRphsgAW+gWjDJnqoS2g0AsmPOR6FA7+noWf0S08zE3gBgttVOWeUwNsTVvy KPhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zliD2Qsx7OubU1h4LVAM9OejLzFcsBaCjZJRdpEsKrg=; b=ccMiCpPA8OcMmglZWaMZ6TZhmi/V8JqEy9unmNDs67w0pQ+qEmdv4dUzz9r1jmuT1X bT1wkNAe1YbwKWWAiGfCh7rcnWXdGpWbd4YlOleHDMqCupa7oWLwZc0q2zQg6eInM+n9 ssGxG3S2/UYp5rbtv7nqWBahfhAduFFM0Hq63/OLZGrfWvm+OQtoYx1olNbx8IYIEVTK jPtmq86qVKlT/UMSiAYs1RPh4b+/x9wZYg7B+xhXBT/CJKVY0bm9u+UgpB5FYFwEBMRh saFuLtwr6KVYuECFVkLCuZvfpcRK3h/wvRXCE0yMUuvE93Lz6DQm+G7LULiVVdRudf1U KURQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Pz4gqJjl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k199-20020a6284d0000000b0052565bd6e71si3435806pfd.265.2022.06.24.11.04.45; Fri, 24 Jun 2022 11:04:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Pz4gqJjl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbiFXRsr (ORCPT + 99 others); Fri, 24 Jun 2022 13:48:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232055AbiFXRso (ORCPT ); Fri, 24 Jun 2022 13:48:44 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA7A141320 for ; Fri, 24 Jun 2022 10:48:41 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id n10so2762895plp.0 for ; Fri, 24 Jun 2022 10:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zliD2Qsx7OubU1h4LVAM9OejLzFcsBaCjZJRdpEsKrg=; b=Pz4gqJjlBZdH2FUZf+LZ3Zk2c4Q5PjoLHgSJvUIfFCXLQ3s0DQzl2M7apET6Zy18l+ gg0BY+PsbRil96ZfM2R0pnbNH0l4VO7BByOsiIJRLMuVeDsIjk5zBu5mdXPAuoNx6L7B hNj9RV6ELW7Ls1GQSQx6AOxZK02AhyVXkIwbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zliD2Qsx7OubU1h4LVAM9OejLzFcsBaCjZJRdpEsKrg=; b=hiQHIVPzwloOsiFOde1NAIewV0FPcSSQYfcRU+w21m2ilGO8or5CAGjxUv+w19xvpF FBag7jxx5MdQ6lV02RHrSut0OgxKISPYfSxuVgeLgmsKLaAy/HB6AMJSsGixA5R+EsV9 0EtjVFTIlAbxByUMWWCRRhXONHW9Q3fb1duwri9v2nZaF0oe8nfvKRZEgW4glrC+3X4m LFt0b4/o1ztYqAjWOaB93YbvK2X0IQdSJ4kMM+l7TRWt/5Rj6LbAuhrOfmQ9IO5D7yLV 1dNjxoo3OlVq/zkBlE5fue693JDd5UapwTeZ67ucCynVe3dwqLqFSUBqsJJBYZ+BzMKS fmaA== X-Gm-Message-State: AJIora+Naq1Iz5hHUzoaIN1YntZcqPtgr0qB312D+CD5XHqs2iCvd7cq Mrmrit11CRKJmCgCR+pxR3kxPA== X-Received: by 2002:a17:903:2443:b0:16a:2b65:7edd with SMTP id l3-20020a170903244300b0016a2b657eddmr332318pls.20.1656092921012; Fri, 24 Jun 2022 10:48:41 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 2-20020a170902e9c200b00168ba5ac8adsm2111628plk.163.2022.06.24.10.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 10:48:40 -0700 (PDT) Date: Fri, 24 Jun 2022 10:48:39 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: linux-kernel@vger.kernel.org, Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 3/4][next] scsi: megaraid_sas: Replace one-element array with flexible-array member in MR_DRV_RAID_MAP Message-ID: <202206241047.903049ED@keescook> References: <202206221457.1A12D768EF@keescook> <20220623014533.GA7132@embeddedor> <20220623031401.GA8896@embeddedor> <202206230816.1383511C@keescook> <20220623153825.GA6458@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220623153825.GA6458@embeddedor> X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2022 at 05:38:25PM +0200, Gustavo A. R. Silva wrote: > Which object files are you comparing here? because I don't see the zero > change when comparing the before and after of megaraid_sas_fp.o with > the change you propose. Hm, maybe I did something wrong. But I was looking at megaraid_sas_fp.o -- Kees Cook