Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 11:32:55 -0700
From:   Zach O'Keefe <zokeefe@google.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org,
        shy828301@gmail.com, willy@infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/16] mm/huge_memory: use flush_pmd_tlb_range in
 move_huge_pmd
Message-ID: <YrYDVzT48IhLhwKQ@google.com>
References: <20220622170627.19786-1-linmiaohe@huawei.com>
 <20220622170627.19786-2-linmiaohe@huawei.com>
 <YrQInzK5g/NJMmSA@FVFYT0MHHV2J.usts.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YrQInzK5g/NJMmSA@FVFYT0MHHV2J.usts.net>
Precedence: bulk

On 23 Jun 14:30, Muchun Song wrote:
> On Thu, Jun 23, 2022 at 01:06:12AM +0800, Miaohe Lin wrote:
> > ARCHes with special requirements for evicting THP backing TLB entries can
> > implement flush_pmd_tlb_range. Otherwise also, it can help optimize TLB
> > flush in THP regime. Using flush_pmd_tlb_range to take advantage of this
> > in move_huge_pmd.
> > 
> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> 
> LGTM.
> 
> Reviewed-by: Muchun Song <songmuchun@bytedace.com>

Reviewed-by: Zach O'Keefe <zokeefe@google.com>