Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 16:44:32 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Leon Romanovsky <leon@kernel.org>,
        Mark Zhang <markzhang@nvidia.com>,
        Maor Gottlieb <maorg@nvidia.com>,
        Weihang Li <liweihang@huawei.com>,
        Wenpeng Liang <liangwenpeng@huawei.com>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/cm: Fix memory leak in ib_cm_insert_listen
Message-ID: <20220624194432.GA281681@nvidia.com>
References: <20220621052546.4821-1-linmq006@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220621052546.4821-1-linmq006@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4+eV5IyC4b6k31bbiIgujoib3qdEZEisP6NbVz/HZdJaLI8GTsxA0DEiFAl5?=
 =?us-ascii?Q?LE9a1+1eqvWN77jqiTnbOI6Ac3ZKCDu9vAVnht6yQiaZIgStsxlFtD9N2TbK?=
 =?us-ascii?Q?D4cKXhuatJgaa512igmddFzgcIewqv+3Tfw1u1FZ+DwnRDq+a6CfuQ3yR1pe?=
 =?us-ascii?Q?WllQjnMyfQEYE/LocfWAcurTbJJvG1rvfVmQBsRaDQ0ULqi8vyelBd7joFRo?=
 =?us-ascii?Q?xFi4MyLMZa2kt5UFa5AWJg7wLgbQ1N/NXyxbEBAgH4hQQniTT+Dqnv4lun4G?=
 =?us-ascii?Q?vGe0XB//lbbh+7Q4g7Bj//JoLvUkh8G8d5L2qtFJCGisgiyyKEgqJVMPILqU?=
 =?us-ascii?Q?8HMrpffBbBGKedOxCdgkfgSTrMbn4ikEqEY3N0r2bD/7WcgExatA83set3kG?=
 =?us-ascii?Q?d/pK750OB1yPeoUKhYITw1WR2fe2YrUiNAAT3T19xU7ypZMVNwwPyeUry+I4?=
 =?us-ascii?Q?tp2lICDHEjErxqd1vBC65vDqRAlEnXz3JdHG5J67a+fXKa1Q1I9QK4KgM0BE?=
 =?us-ascii?Q?NUC7ndeGntWzY2AJDBYilA61qZO3hORcZos8+EpuDGTzHoMp/fsgIkuj4Nrb?=
 =?us-ascii?Q?2V44/0WsKpz1dGWkSNa4Gcf15JcctseLAnDha3uRRof2RlBzUxbWaZIBWIMV?=
 =?us-ascii?Q?CaWzKFjRfhUiBCJ6JKFSqazGms5PLToES7TIcNCs7BWgF+4ii7T6mE26del4?=
 =?us-ascii?Q?BgVOUNyQH/cl8s/Mq/+44Yf1CWN8Gyyr6IMmr/hFm9z0QzZpWpBAXKR+za0I?=
 =?us-ascii?Q?9qkcsnzpZ/2M089Nd+wlYjqKiOdh8ARo1dmAS7QADH6r5J6Wcz/yJJByHJUe?=
 =?us-ascii?Q?kc9DOPSFykrsgTSFGxXEN+vX+cqFl67yYQ5MTs/XZYh+/IqWOHZURKIOvIql?=
 =?us-ascii?Q?d1um3y+Pop4dnQfqpGbIjtj5O6UAuRYf5AX9wg99EtS/VmVulKFpNY1M1PHI?=
 =?us-ascii?Q?uIIqjPsp1R7sSa7hfwJtpFxIWSI2eGWvU4i9wHQlAYYljkc6+gRpLe0aNJ9n?=
 =?us-ascii?Q?RXkxg16NmzKmKJc3yP8ahGL0NEL3FzUbCYu0rIJAYbsTR5TqhiJfjrrCHn/k?=
 =?us-ascii?Q?+PARPz20lsoF71mQz/JzUXT2JbxeAu6aRI5unDVaU6m5U70tKKP5v0JwsqIP?=
 =?us-ascii?Q?VRpxRbxRUztcVoYI4il43oUYFRDAxK6hKS9DTg4Q3Jhrvmn2K+W6cjPj5EvE?=
 =?us-ascii?Q?8UJ4FOqzagh71R9zf3SdSCYKHiZm0LW0fQE9+xCru8xrppj/jcznrAEvdS5S?=
 =?us-ascii?Q?p/HbbBDX1OK2F2moVFBbooD05wB8wbcg9lU4Ik+y69vbJPZV089byibKSXeI?=
 =?us-ascii?Q?ATu9PWWc1Z8IGILZp060dltzvg63PogEilgz1Eug3gNTFOfkYr4Bmk3DaVnb?=
 =?us-ascii?Q?ex/0LqQjF7BiBMjTK+9CPTAf8nb6RwkGxVebuot7Wi7Wh2XyTa3SaaUZ1yWF?=
 =?us-ascii?Q?NVk3e1LHj5a8lWIdKCMwCl+hethOOGeQrh4PiB34p6xTGYDf6izEuYF/U03Y?=
 =?us-ascii?Q?seY3dAMjNa+bCmnrF8MxYG8cXWIgu0qoxzF4DvqXrVhu8xZ23XZjUzvhbu+s?=
 =?us-ascii?Q?pVKSa1eMfoGnk3BVzwIacULNvhhh9P5GEX8HZNOD?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a453cc15-ba7e-49c3-51e5-08da5619f6a3
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 19:44:33.9822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ewdhw+h3q6S1gQ21h7x7Elpd9waKFNNrPdbBw0BQFgCXBlfee/Fmcd4x5TohqwGj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3397
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 21, 2022 at 09:25:44AM +0400, Miaoqian Lin wrote:
> cm_alloc_id_priv() allocates resource for cm_id_priv.
> when cm_init_listen() fails, it doesn't free it,
> leading to memory leak. call ib_destroy_cm_id() to fix this.
> 
> Fixes: 98f67156a80f ("RDMA/cm: Simplify establishing a listen cm_id")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  drivers/infiniband/core/cm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied to for-rc, thanks

Jason