Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <YrXo+i3wwl2ERKIj@xps13>
References: <20220623142837.3140680-1-bmasney@redhat.com> <20220624002055.58BCFC341C0@smtp.kernel.org> <YrXo+i3wwl2ERKIj@xps13>
Subject: Re: [PATCH] clk: qcom: sc8280xp: add parent to gcc_ufs_phy_axi_clk for sa8540p
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
        agross@kernel.org, mturquette@baylibre.com,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        ahalaney@redhat.com, echanude@redhat.com
To:     Brian Masney <bmasney@redhat.com>
Date:   Fri, 24 Jun 2022 13:16:49 -0700
User-Agent: alot/0.10
Message-Id: <20220624201652.04747C34114@smtp.kernel.org>
Precedence: bulk

Quoting Brian Masney (2022-06-24 09:40:26)
> On Thu, Jun 23, 2022 at 05:20:53PM -0700, Stephen Boyd wrote:
> > Quoting Brian Masney (2022-06-23 07:28:37)
> > > diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-s=
c8280xp.c
> > > index 4b894442fdf5..4639b50da418 100644
> > > --- a/drivers/clk/qcom/gcc-sc8280xp.c
> > > +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> > > @@ -5696,6 +5709,7 @@ static struct clk_branch gcc_ufs_phy_axi_clk =
=3D {
> > >                 .hw.init =3D &(const struct clk_init_data) {
> > >                         .name =3D "gcc_ufs_phy_axi_clk",
> > >                         .parent_hws =3D (const struct clk_hw*[]){
> > > +                               &gcc_ufs_ref_clkref_clk.clkr.hw,
> > >                                 &gcc_ufs_phy_axi_clk_src.clkr.hw,
> > >                         },
> > >                         .num_parents =3D 1,
> >=20
> > num_parents needs an update.=20
>=20
> Oops!
>=20
> > But this is a branch, not a mux, so it can't have more than one
> > parent.
>=20
> Would a mux be represented with 'struct clk_rcg2'?
>=20

Could be. An RCG is more than a mux, because it also has a divider and
an m/n counter.