Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 13:57:57 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc:     linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Liu Shixin <liushixin2@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Oscar Salvador <osalvador@suse.de>,
        Muchun Song <songmuchun@bytedance.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/9] mm/hugetlb: separate path for hwpoison entry in
 copy_hugetlb_page_range()
Message-ID: <YrYlVdXV+TFLDAGs@monkey>
References: <20220623235153.2623702-1-naoya.horiguchi@linux.dev>
 <20220623235153.2623702-3-naoya.horiguchi@linux.dev>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220623235153.2623702-3-naoya.horiguchi@linux.dev>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?09zZHU015/Bv7EX7ONsp+TFuc/Fh/zTN1yYSyA0IssBVby6pSr1un+db3+tX?=
 =?us-ascii?Q?SruxrEeTfVVfsYZpemBwiKwKCL/XxctBU8k2iAorgG+Qu+uM9dcbN4mIWXyS?=
 =?us-ascii?Q?z8CpHtP6YCOxrLgcqzUW/dzjySZse6qTqUTJFPrsDlmwN4XFrRKMWUAUYIIx?=
 =?us-ascii?Q?qFeUaBk80QpETMquhQE1m0stIhSu5HBtI9n6mQc114cbm5vWs+cKGtjp4mRd?=
 =?us-ascii?Q?vaVoxsURc/EZBm49oB0G8jWpI7AmnGipwKHyN84F0hYJFp04UGLZcxo932Sc?=
 =?us-ascii?Q?NIqhmbJ/TMjo+8xYGIQW/lY0lKQn/+j+q0suUFVKS2ImOCTUuHoubAMDEYJG?=
 =?us-ascii?Q?VtTynNC9N4PjwJqGw1WFQuCgqnhJ/w5g0HNaSftRi0xLeNRl+yoIf+aiyLoF?=
 =?us-ascii?Q?qZgMJbr6M60zuK8JVqnYtsxysmgLtrD7+w3Sg4I1TMDybgYKZJC5MQdeYp94?=
 =?us-ascii?Q?IfzfWdh0qQ6VfBCh3bXywjmjD9qo7RUfy1WMq2gRzxmaUy9N1c9y3RuD/Oux?=
 =?us-ascii?Q?LSHQK9MiWpGCcf4XfnvfI8kC0qYKKKIXXdeWs/I98q40P80nJprsuTY3sQp4?=
 =?us-ascii?Q?1S6+cFt9+wPDzHxXfl+7KUAYQxCGo+xvybVs1L/mc1H3/458eldDS+J20kYb?=
 =?us-ascii?Q?tO+4na+Aa4wluEZlfCrP3B7wAP2ZRGs6O/hftv4Qj8zMadtpJNGqJZ1aV0Qn?=
 =?us-ascii?Q?j0t2HwfvpHbwgx4vqx8J7ahsDj4tXLY1IbLQXHXYll3/9mgzsjR00RW2TYxi?=
 =?us-ascii?Q?S1+vQCBC/Vbij/BvM5NgTQZLAjmmdQli+AsqH4jQbb8NxKYW8Dqxt7vB5Nwp?=
 =?us-ascii?Q?5Sia+G+sK0Y5MbJqM0aBQ2IQJIvUMQq4XzUu6vrAhCYWMpdey5hT33Obyw2A?=
 =?us-ascii?Q?NL0Rd8Yo+gUVfTDMrYOfLI7btKXhl6svkjVR8VOUb6y8ZSzv6gHRAlkGNjUy?=
 =?us-ascii?Q?JgOWidDFASUuoNXMqYaQXfZaXEQ3fdty3ynzIl7gfMbwV46V66bAyPJJ5x3h?=
 =?us-ascii?Q?LRh+cu+nFGv0AIh51CwACS0IFvx5Z7zYGfqvJQbg0EqxdUxdrIKyjnlT1RLq?=
 =?us-ascii?Q?69+u2W2li/0ETGs4pNQRSVkv4xY8zAoI8wOpEBHV/FogIQM/cdDBsxXOoNKn?=
 =?us-ascii?Q?qmB5T+BRwksqFNVvMLlBt2kdQ8uporjN/QQ6ZFLIIo4zPZ9rU5aM3yAiW8Jx?=
 =?us-ascii?Q?rSOc9sC6Uz/zhf/+mc7VsaaOMbbC1Qrf/6xlXcorS0RLkszQ37QD6ITgqEYW?=
 =?us-ascii?Q?uur9vsWJx9J7nQdxNTVCVssewrXKBLiOU/wCLDO7YCxiWdovEQTNYRBs3Rbi?=
 =?us-ascii?Q?1Yl8YZuyFWhkj+YPNZRZlVxpF4ec5qUbmt00fHPT+95IYyzs/R1GGJta7h3g?=
 =?us-ascii?Q?BrLb7PZX74One5vI4HlV8U7mtnhvMCzdrxKHTJHDh4oImvZVYdOghJGHUHgY?=
 =?us-ascii?Q?ew/zUYZDYIms1/5T4HcUXoGg5IAZsjf8B1ygb2tjBtSw20hUUObod5td7E8z?=
 =?us-ascii?Q?gCkGwUKPHU33adIzMIjEcpyvdtLHHP/Sfi913k1m4jqzubjaWjbZRKb07WJ4?=
 =?us-ascii?Q?pebie1EiAFbivXba6ryKQvbHwFtX239ac+OJfYsV5EtxZoPfP/9N1c0dZxft?=
 =?us-ascii?Q?Nw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fcaa1de-2da4-4d60-7d0a-08da5624392b
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 20:58:00.5885
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AMzqlD//nFTiLAasTbGc0HcfnpcmJPixhphvg9qTG0sbVnW7ipONuQLdL5ANr5rEf5SD++Nxz1bPcH+htdHbRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4475
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-24_09:2022-06-24,2022-06-24 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206240080
X-Proofpoint-ORIG-GUID: nIv-FMF51KhAGXAjpP9HMUvYh_W9h0lw
X-Proofpoint-GUID: nIv-FMF51KhAGXAjpP9HMUvYh_W9h0lw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/24/22 08:51, Naoya Horiguchi wrote:
> From: Naoya Horiguchi <naoya.horiguchi@nec.com>
> 
> Originally copy_hugetlb_page_range() handles migration entries and hwpoisone
> entries in similar manner.  But recently the related code path has more code
> for migration entries, and when is_writable_migration_entry() was converted
> to !is_readable_migration_entry(), hwpoison entries on source processes got
> to be unexpectedly updated (which is legitimate for migration entries, but
> not for hwpoison entries).  This results in unexpected serious issues like
> kernel panic when foking processes with hwpoison entries in pmd.
> 
> Separate the if branch into one for hwpoison entries and one for migration
> entries.
> 
> Fixes: 6c287605fd56 ("mm: remember exclusively mapped anonymous pages with PG_anon_exclusive")
> Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> Cc: <stable@vger.kernel.org> # 5.18
> ---
>  mm/hugetlb.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Thank you!

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
(with typos pointed out by Miaohe Lin)

Just curious, are there any hwpoisoned tests in any test suite?  I run
libhugetlbfs tests and ltp on a regular basis which sometimes catch
regressions.  If there are no tests in any suite today, this might be
something we want to consider for future work.

-- 
Mike Kravetz