Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 23:05:25 +0200
From:   Stephen Kitt <steve@sk2.org>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Alessandro Zummo <a.zummo@towertech.it>,
        Dianlong Li <long17.cool@163.com>,
        Wolfram Sang <wsa@kernel.org>, linux-rtc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: use simple i2c probe
Message-ID: <20220624230525.0b78a0e9@heffalump.sk2.org>
In-Reply-To: <YrX3mWxDex7OuEpn@mail.local>
References: <20220610162346.4134094-1-steve@sk2.org>
        <YqSnwf7paZa1+uuh@mail.local>
        <2bd6ab78f649ba282c5369d0e969fea2@sk2.org>
        <YrX3mWxDex7OuEpn@mail.local>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/zcUjq.t0PedMxF0zVF7vJxa";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/zcUjq.t0PedMxF0zVF7vJxa
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 24 Jun 2022 19:42:49 +0200, Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 12/06/2022 21:23:47+0200, Stephen Kitt wrote:
> > Do you have an example of a change requiring id to support RTCs on x86
> > systems? =20
>=20
> I checked and your patch is actually fine, the issue I referred to is:
>=20
> 1c1b3098ae1e ("rtc: pcf85063: add i2c_device_id name matching support")

Ah yes, I see! The changes I=E2=80=99m making are compatible with that (as =
you
figured out), I=E2=80=99m not removing the id tables, just avoiding calls to
i2c_match_id when they=E2=80=99re not needed. In fact the approach I use fo=
r drivers
which do need their id tables is the same as in the commit above, with an
explicit call to i2c_match_id instead of the old-style probe.

Regards,

Stephen

--Sig_/zcUjq.t0PedMxF0zVF7vJxa
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmK2JxUACgkQgNMC9Yht
g5w0yg/6A6hxeeRgI0j1ocMrEZRUHdyTQA9xnNLb+/A6M6NwEtm6rCeBi7JwvTvl
yWn2KbqShV7wcc1GiNKgCDPMWosl3nVNaJQlM6rSr3ntk+9Zkj/JaN6AIVTOQpl5
zEl5GGfh6kjD3e4MlffHFek8Iap0xLUO7ocj+t4+73xzvwLZgK4gVN2qlR5E+dan
+uoD8KVY2zhemakk05ZXs96n+owJsPJfDWo+MLNqYq04kI/IbDCsojVo5P6oWQNH
Ivh2pkFPwawyQZyOwNF6Fa43rHopSHu8lxGNYWhN5A8odivmmOn91oRi80CjXDfo
DfX1MOhhG6QD4zv7UzrmJqrcym+PZZczA2qcE2x9IO8KXyQ2hEfO+711r+swF2/H
6CcAUc5sc+LOnjN/e4BFt+V0fCpYHZoBEdVpHfkuniuIrReMALHLqmlWTfG2Qi48
EpAvo5oooB9xqHwYJ5Wjd2ZkcoUGTNmPuO+Iv1+TF1RzqXY/7p0tcBl08rB46Dry
9mDbjQu7X0WeBkEEPO0MSCaJeV9kFhWMKna8JB3Kvb9aQlQA1y1vFIEKrQaVuLGy
aBXeZvHinsd3wNq9q/FOWyrmXybTpIGt8JbaMO1vVHD3u6ZBj6pC6QHMsRa6557g
cK30IBS4qLcntohfmDFrNQ/FU8u9APFCCzVPOPOE+zmC/amxXZI=
=y/QV
-----END PGP SIGNATURE-----

--Sig_/zcUjq.t0PedMxF0zVF7vJxa--