Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp808770iog; Fri, 24 Jun 2022 14:50:28 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tnS76tlP629PQwNLrTCx9KKbXj25bNBlU3czwlUG2qo5ZgCfCReOjPTuvnx6BJ1TyBOI9n X-Received: by 2002:a05:6402:4248:b0:435:9150:ccfb with SMTP id g8-20020a056402424800b004359150ccfbmr1496610edb.374.1656107428123; Fri, 24 Jun 2022 14:50:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656107428; cv=none; d=google.com; s=arc-20160816; b=WTkwkNrQ2gYD1s2dDC9ZEBM1/fWKKlZW9mtoinY7MMYuXWWJEw+ZvmXl8528YRDhjX eGyD5EUEEu720KxG4G6GLgYqced4LFcQOgGJpnMps8EEJ2IHGx4M5GrwKqOmQBMqBVMe qp/tzS4dT2jWrt/2hcdtFbQ8MUjjxFvL9XKoG3SZk9K6O7Chh24q/aubarGv9oI1f1WI YRDkWOmQxmXC/H1GkPC6TEDx05qNJEAorkoiRI7WEyP7kWyd/QmiL6tZI+2BTdcEx+io RJyKUyNXLyoHBlq3xx7jnmUdD2gB4nglm/WpLWE/g4nX9Aoo56NCk3tBcNshGX/QqlPy 6E0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=cGTylEOWtLkcLIsxYVoGzfL+q0nSap9+8NoSlXBuXe4=; b=1FMieEGZL6Ve9yOkYzNBzomH2mr9p9ihNU5Am46z+R/6ZBEhSZWZTsEZLW4HcAHxhT 6pTfneWcYhDhDmuacUE68dKkgBAdHAYqnYxMS6bkClVUuyZ/JWgflxEtCmS6CFQh/5P6 UYH54vQYxSCn6KhDxvHRl2KHRA0cyNAF7boS/Q5FYvux2UKUGMsXep6TMfi03aX3lDnF EH2l6KG6IxIM8CfI2FV2viwhl1RiCgi72xRKEDjZ8a8umxB5i4syZ35bD1WwALhoT69v sJ0sD/O0jyWCVREm6rzRSwHv5csR2ieu6pVCsSk5bPy9RHFh7RYoa9tbe1Yd/xT2V1w6 +xLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cmDy8lsy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t9-20020a056402524900b004357f301eedsi5115878edd.615.2022.06.24.14.50.03; Fri, 24 Jun 2022 14:50:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cmDy8lsy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231725AbiFXVgV (ORCPT + 99 others); Fri, 24 Jun 2022 17:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231654AbiFXVgT (ORCPT ); Fri, 24 Jun 2022 17:36:19 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 583513EAAE for ; Fri, 24 Jun 2022 14:36:18 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-2ef5380669cso36560247b3.9 for ; Fri, 24 Jun 2022 14:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cGTylEOWtLkcLIsxYVoGzfL+q0nSap9+8NoSlXBuXe4=; b=cmDy8lsyV2rPNiNRuYkEb5rHWD8XZVHKqJZAeKf3TnWZFLlj+/DTdLUMbXEmtTuv9s 4KLbNJHfJqFtWZDtoSIB0jA5BkjqsNets6Rbr/qrINRnJTlQirI2k20GLR/Ql3zSe9Wq Pb5aXUq1NZ5lDKQQMD7a39HTujZM62LjFsQtIqhJoX7pGAoQGMqpg1+inV2FswApITO2 CmT3BH618Yqgt62CZsqxQ5e1jZosKUxMbd0fExcTgjLrAxPBxkG7CVcmjw/O8dvTmdbG l6UouC6UHf0T16KEM/mMUtmMtJOh0vyJl540PkTEmkGnFr3Ic8OHzXavkS9AsevSsxDH c7uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cGTylEOWtLkcLIsxYVoGzfL+q0nSap9+8NoSlXBuXe4=; b=Ck47hAgGjuuZjSk05lJ4a11GaykJMF2di9lXeAQ7yb6p/6BiKyGsIK//4xvAXu5Zsy SvwPouPn6QVjgYaavxtgw8prA1415weMg4SE93rYiLbZlzxYWj1aPLEYiufxgdWajIA0 vwrzWIa+MB9DBZK5vL1Kp3i8MlA3H3zJjmWMxgin2Iv3pRXuaWrnSU20oi7Tv8tZMvfo ARTcKWhPNNp21pKmlpoUPrxrWuqP/+ku1GR56ag1D9uJ40xatxKhJcXfxpsmdBGp5Pvc zAAXXux16IYGaWGRMHdqIbdAQvMgvjYlKrBPhuavwduKV6O2tITCbJ9ohgot+6e1ner5 WxSg== X-Gm-Message-State: AJIora8tN+D1rPar/GocM6bzEF+WGbJ8lfPH9w1bjsN1p13QVJ1EBd/D uOQADGrvtL9JMLcjQrLy8mfoJ/KyRPdu6BDNGuKocw== X-Received: by 2002:a0d:cc54:0:b0:317:752c:bcf3 with SMTP id o81-20020a0dcc54000000b00317752cbcf3mr1068283ywd.437.1656106577632; Fri, 24 Jun 2022 14:36:17 -0700 (PDT) MIME-Version: 1.0 References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-13-peterwu.pub@gmail.com> In-Reply-To: From: Linus Walleij Date: Fri, 24 Jun 2022 23:36:06 +0200 Message-ID: Subject: Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support To: szuni chen Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , devicetree , "open list:FRAMEBUFFER LAYER" , alice_chen@richtek.com, Linux PM , linux-iio , USB , Linux Kernel Mailing List , dri-devel , ChiYuan Huang , chiaen_wu@richtek.com, "moderated list:ARM/Mediatek SoC support" , linux-arm Mailing List , Linux LED Subsystem Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2022 at 9:20 AM szuni chen wrote: > > I meant this one. Move that into drivers/leds/flash > > drivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++ > > In next version, I'll use "leds: flash: ......" instead of "leds: > flashlight: ......" in subject. > May I confirm that the driver has already in the drivers/leds/flash, > so I don=E2=80=99t have to move it in next version? Yeah you're right, I am just writing wrong comments today, it is already correct. Sorry! Yours, Linus Walleij