Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a210c39-2a04-2d39-9d5f-51b4e777b81d@infradead.org>
Date:   Fri, 24 Jun 2022 16:04:01 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 3/3] ASoC: amd: acp: Add legacy audio driver support for
 Rembrandt platform
Content-Language: en-US
To:     V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
        broonie@kernel.org, alsa-devel@alsa-project.org
Cc:     Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, venkataprasad.potturu@amd.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Arnd Bergmann <arnd@arndb.de>,
        Akihiko Odaki <akihiko.odaki@gmail.com>,
        Jia-Ju Bai <baijiaju1990@gmail.com>,
        Syed Saba kareem <ssabakar@amd.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Meng Tang <tangmeng@uniontech.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20220624194821.287462-1-Vsujithkumar.Reddy@amd.com>
 <20220624194821.287462-4-Vsujithkumar.Reddy@amd.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220624194821.287462-4-Vsujithkumar.Reddy@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 6/24/22 12:48, V sujith kumar Reddy wrote:
> diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
> index 7e56d2644105..abc089f38b6c 100644
> --- a/sound/soc/amd/acp/Kconfig
> +++ b/sound/soc/amd/acp/Kconfig
> @@ -40,6 +40,17 @@ config SND_AMD_ASOC_RENOIR
>  	help
>  	  This option enables Renoir I2S support on AMD platform.
>  
> +config SND_AMD_ASOC_REMBRANDT
> +        tristate "AMD ACP ASOC Rembrandt Support"
> +        select SND_SOC_AMD_ACP_PCM
> +        select SND_SOC_AMD_ACP_I2S
> +        select SND_SOC_AMD_ACP_PDM
> +        depends on X86 && PCI
> +        help
> +          This option enables Rembrandt I2S support on AMD platform.
> +	  Say Y if you want to enable AUDIO on Rembrandt
> +	  If unsure select "N".

Documentation/process/coding-style.rst says:

10) Kconfig configuration files
-------------------------------

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


so please indent as expected, and consistently.

-- 
~Randy