Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <241393bf-1fd3-ab25-867b-7132d7590aa8@gmail.com>
Date:   Sat, 25 Jun 2022 08:15:43 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] media: docs: Modify the section of User xattr
Content-Language: en-US
To:     Deming Wang <wangdeming@inspur.com>, miklos@szeredi.hu,
        corbet@lwn.net
Cc:     linux-unionfs@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220624014605.2007-1-wangdeming@inspur.com>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <20220624014605.2007-1-wangdeming@inspur.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/24/22 08:46, Deming Wang wrote:
> Delete duplicate words of "the".
> 

I think "Modify something" isn't clear subject, because reviewers
don't know at glance the logical change this patch is doing other
than actually reading the diff below.

For the patch message, what about "Remove duplicate the"?

In this case of trivial patch, it's OK to have the patch message
same as the subject, if the message can't be described more
concise but clearer.

> @@ -607,7 +607,7 @@ can be removed.
>  User xattr
>  ----------
>  
> -The the "-o userxattr" mount option forces overlayfs to use the
> +The "-o userxattr" mount option forces overlayfs to use the
>  "user.overlay." xattr namespace instead of "trusted.overlay.".  This is
>  useful for unprivileged mounting of overlayfs.
>  

The diff looks OK.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara