Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 18:57:14 -0700
From:   Guru Das Srinagesh <quic_gurus@quicinc.com>
To:     Robert Marko <robimarko@gmail.com>
CC:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: firmware: qcom-scm: convert to dtschema
Message-ID: <20220625015714.GA6675@quicinc.com>
References: <20220623182542.1116677-1-robimarko@gmail.com>
 <20220624010103.GA23758@quicinc.com>
 <CAOX2RU7yKuV4i_9YRs9fx2DTTvAndWFFw3cYtQ3qFk9m1zZJVg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAOX2RU7yKuV4i_9YRs9fx2DTTvAndWFFw3cYtQ3qFk9m1zZJVg@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Jun 24 2022 10:50, Robert Marko wrote:
> On Fri, 24 Jun 2022 at 03:01, Guru Das Srinagesh <quic_gurus@quicinc.com> wrote:
> >
> > On Thu, Jun 23, 2022 at 08:25:42PM +0200, Robert Marko wrote:
> >
> > > +
> > > +description: |
> > ...
> > > +
> > > +  '#reset-cells':
> > > +    const: 1
> >
> > This isn't part of the original file - could you please explain why this is
> > being added?
> 
> Yes, its not part of the original file, however I noticed that a lot of SCM
> nodes were adding #reset-cells, and upon looking at the SCM code its
> clear that it is being registered as a reset controller so #reset-cells are
> appropriate.
> 
> However, since its not really being used via phandles #reset-cells did
> not really matter, hence why I did not add them to be required,
> this is something that DT guys can probably clarify.

Makes sense, ACK.

Thank you.

Guru Das.