Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1133523iog; Sat, 25 Jun 2022 01:39:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vbzM8qtFCDs5WuEMHkqsYRII5T58j4BkmWn8HCvs0nvV2adixy1dUZzJnaNX5ypVmGY0mT X-Received: by 2002:a17:907:9627:b0:725:be17:b3d0 with SMTP id gb39-20020a170907962700b00725be17b3d0mr2855409ejc.45.1656146349080; Sat, 25 Jun 2022 01:39:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656146349; cv=none; d=google.com; s=arc-20160816; b=Del8Bi7c/i029pA+NCnfrvm7/wmAL/C6QHxoidM/31xxNSiTSNXVX2d0DMftwOiggz vQYtqUKKjUMD9y8eTxOymSk/NHc9JYl2y/CFLdUrqXCP+w3jRlcqOw7AC+VWGubPpcct 0HPXO7TjuxuD0eH7ZD2PWJEaBqEW9UlbuVRRfRE48QZ7hCyALl1mluKjBrFTpsteLu9p S+vP1xL+1JOFiF2XbIoWZz2obWHdxxdbHRGj2KK8zNzL+k2LBLUrVo+DNCHifkNn4oqd vMA2YoGymOMI0k9yx78YrSZCtc7/S2k38grmFZgvME28WeQRwN/MO4wyrG+ZO4SSEAz/ Px1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Pgxk4GfqdEazMAaUU8Vogm2IvjJWif2mBoFjn2TkMjk=; b=BRAdx4HT7vcV2VyngDzvnQNMQperbSRdCU0HXM80uL0EhU1IovxHm6IhL5QmQ74BY/ xbq+SwQJY3Y3GOjiECxjjkYvXJh9WfcrWuzsobvSfl29dl/JnxEaSIzGuVb6j0fF4Qhf 95gMZgrN+c5t+1VS6XdLlzlnTkArcMcpahEbRfABbr/LUdx1nzHq/5+JREJjI46VpMfu w8k4OSj4tNcfD+T3bRgJlL+i6qr6w/7nW50b1tGkVRxwMfwuxAJE84NadmhLRlw3uwx/ LB4Ur+1Jey2Z8oENqxLYjwcGfejrmnvmtLehj5X8Jb+KnR+zhSXbia3NdtiJmpO6x6wT OQEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=Nf+lUCla; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t4-20020a1709067c0400b00707f49cf9e6si5076192ejo.68.2022.06.25.01.38.43; Sat, 25 Jun 2022 01:39:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=Nf+lUCla; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232118AbiFYIP4 (ORCPT + 99 others); Sat, 25 Jun 2022 04:15:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231752AbiFYIPz (ORCPT ); Sat, 25 Jun 2022 04:15:55 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 200A33136A for ; Sat, 25 Jun 2022 01:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=Pgxk4GfqdEazMAaUU8Vogm2IvjJW if2mBoFjn2TkMjk=; b=Nf+lUCla94gyxk8LVQxRbj9mYLSCbDmDWziQGqiEJWUx Xvi6U2bnZGYMyHW3ugkYNa9KaHaYbDloZj/Ijh4tSbltdUBe7NLEy3fqCiEfe8CD myzROIqI2UYIuJaU2WKPcwWe/YsU4puPWSPtJsSIdhWD2ICCXJBJmMF1EQgr5zM= Received: (qmail 1730323 invoked from network); 25 Jun 2022 10:15:48 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 25 Jun 2022 10:15:48 +0200 X-UD-Smtp-Session: l3s3148p1@9S9VS0HizZgucq2i Date: Sat, 25 Jun 2022 10:15:47 +0200 From: Wolfram Sang To: Lad Prabhakar Cc: Ulf Hansson , Philipp Zabel , Yoshihiro Shimoda , Geert Uytterhoeven , Pavel Machek , linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das Subject: Re: [PATCH v3 1/2] mmc: renesas_sdhi: Get the reset handle early in the probe Message-ID: Mail-Followup-To: Wolfram Sang , Lad Prabhakar , Ulf Hansson , Philipp Zabel , Yoshihiro Shimoda , Geert Uytterhoeven , Pavel Machek , linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das References: <20220624181438.4355-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220624181438.4355-2-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uukWhCvGKCjJxTsP" Content-Disposition: inline In-Reply-To: <20220624181438.4355-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uukWhCvGKCjJxTsP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 24, 2022 at 07:14:37PM +0100, Lad Prabhakar wrote: > In case of devm_reset_control_get_optional_exclusive() failure we returned > directly instead of jumping to the error path to roll back initialization. >=20 > This patch moves devm_reset_control_get_optional_exclusive() early in the > probe so that we have the reset handle prior to initialization of the > hardware. >=20 > Fixes: b4d86f37eacb7 ("mmc: renesas_sdhi: do hard reset if possible") > Reported-by: Pavel Machek > Signed-off-by: Lad Prabhakar > Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang --uukWhCvGKCjJxTsP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmK2xDMACgkQFA3kzBSg KbZ6vw//dYXe8UJWJ4MK6BZEyBiOHEgwHi/XvYWgWd7XgvHGqEbxS/zHZfkp7sjH CBm7q7lDmwoNpcyNIWxeTYalAnTMMLSjNu7aV112qc58Bj6DmyuvHvP0kN+eD8dP wyTGXkW4hEhLvAuHWhocPoS1iQ9IHiOCOqS9vyO7ClKkEKJIflbJqI1RCeUc4BVS C3WAmfLFtorwQGt44IQJ7NteAcpxbwF+o4oG59o86DkdscbHlQNxEEJDnAqPz8Cb 3rVkO7g1NnF3NsO4ko2uFEoyMa5z1lkkvGIztdLHczg6nDUIWtjpqAC1/tzbK8u2 emgJfmKpULEivIMt1TBSpRAdJHK0gqt5Q4IuZzy4R3VQjOkaODqoEVwPiRYBf5qU 34QaH31pbHbqqKk8X3b98J5jZXr17KsguZMYUXHb4ivl/kFHH8U1rMhppSdIK0to VRNarMDkOkQG31vWyjYhydHRzNlyXTdnqUoQ38MP5eTbJSge3GapAvK02ilA5VJG KipMmBmWh3jDoLPYBqEIXfbRbk071HDqsP15CySUDQgS+dTDjSqFLf27qsjMy8xe bqifTDsBZGrjsxrw7ztCiJCwbIJ7zQJanHghAMsfje3I42WLGRpc8fgfz8uBijnp mnXAInO8quyuOiWRLEq+PqVrJNOMOZZYB+jLj492RttIDQnOPog= =TIva -----END PGP SIGNATURE----- --uukWhCvGKCjJxTsP--