Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 25 Jun 2022 17:36:34 +0800
From:   kernel test robot <lkp@intel.com>
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
        Catalin Marinas <catalin.marinas@arm.com>
Subject: drivers/message/fusion/mptctl.c:1492:9: warning: 'strncpy' output
 may be truncated copying 31 bytes from a string of length 31
Message-ID: <202206251758.8S6r2m0M-lkp@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Precedence: bulk

Hi Kefeng,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8c23f235a6a8ae43abea215812eb9d8cf4dd165e
commit: dd03762ab608e058c8f390ad9cf667e490089796 arm64: Enable KCSAN
date:   6 months ago
config: arm64-randconfig-r015-20220625
compiler: aarch64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dd03762ab608e058c8f390ad9cf667e490089796
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout dd03762ab608e058c8f390ad9cf667e490089796
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/message/fusion/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/message/fusion/mptctl.c: In function 'mptctl_do_mpt_command':
   drivers/message/fusion/mptctl.c:1823:27: warning: variable 'config_frame' set but not used [-Wunused-but-set-variable]
    1823 |                 Config_t *config_frame;
         |                           ^~~~~~~~~~~~
   drivers/message/fusion/mptctl.c:2003:34: warning: variable 'pScsiTm' set but not used [-Wunused-but-set-variable]
    2003 |                 SCSITaskMgmt_t  *pScsiTm;
         |                                  ^~~~~~~
   drivers/message/fusion/mptctl.c: In function 'mptctl_hp_hostinfo':
   drivers/message/fusion/mptctl.c:2329:33: warning: variable 'retval' set but not used [-Wunused-but-set-variable]
    2329 |         int                     retval;
         |                                 ^~~~~~
   In function 'mptctl_readtest',
       inlined from '__mptctl_ioctl.isra' at drivers/message/fusion/mptctl.c:661:10:
>> drivers/message/fusion/mptctl.c:1492:9: warning: 'strncpy' output may be truncated copying 31 bytes from a string of length 31 [-Wstringop-truncation]
    1492 |         strncpy (karg.name, ioc->name, MPT_MAX_NAME);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/strncpy +1492 drivers/message/fusion/mptctl.c

^1da177e4c3f415 Linus Torvalds  2005-04-16  1459  
^1da177e4c3f415 Linus Torvalds  2005-04-16  1460  /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
^1da177e4c3f415 Linus Torvalds  2005-04-16  1461  /* MPT IOCTL Test function.
^1da177e4c3f415 Linus Torvalds  2005-04-16  1462   *
^1da177e4c3f415 Linus Torvalds  2005-04-16  1463   * Outputs:	None.
^1da177e4c3f415 Linus Torvalds  2005-04-16  1464   * Return:	0 if successful
^1da177e4c3f415 Linus Torvalds  2005-04-16  1465   *		-EFAULT if data unavailable
^1da177e4c3f415 Linus Torvalds  2005-04-16  1466   *		-ENODEV  if no such device/adapter
^1da177e4c3f415 Linus Torvalds  2005-04-16  1467   */
^1da177e4c3f415 Linus Torvalds  2005-04-16  1468  static int
28d76df18f0ad5b Dan Carpenter   2020-01-14  1469  mptctl_readtest (MPT_ADAPTER *ioc, unsigned long arg)
^1da177e4c3f415 Linus Torvalds  2005-04-16  1470  {
^1da177e4c3f415 Linus Torvalds  2005-04-16  1471  	struct mpt_ioctl_test __user *uarg = (void __user *) arg;
^1da177e4c3f415 Linus Torvalds  2005-04-16  1472  	struct mpt_ioctl_test	 karg;
^1da177e4c3f415 Linus Torvalds  2005-04-16  1473  
^1da177e4c3f415 Linus Torvalds  2005-04-16  1474  	if (copy_from_user(&karg, uarg, sizeof(struct mpt_ioctl_test))) {
29dd3609f2fc70e Eric Moore      2007-09-14  1475  		printk(KERN_ERR MYNAM "%s@%d::mptctl_readtest - "
^1da177e4c3f415 Linus Torvalds  2005-04-16  1476  			"Unable to read in mpt_ioctl_test struct @ %p\n",
^1da177e4c3f415 Linus Torvalds  2005-04-16  1477  				__FILE__, __LINE__, uarg);
^1da177e4c3f415 Linus Torvalds  2005-04-16  1478  		return -EFAULT;
^1da177e4c3f415 Linus Torvalds  2005-04-16  1479  	}
^1da177e4c3f415 Linus Torvalds  2005-04-16  1480  
09120a8cd38dbdb Prakash, Sathya 2007-07-24  1481  	dctlprintk(ioc, printk(MYIOC_s_DEBUG_FMT "mptctl_readtest called.\n",
09120a8cd38dbdb Prakash, Sathya 2007-07-24  1482  	    ioc->name));
^1da177e4c3f415 Linus Torvalds  2005-04-16  1483  	/* Fill in the data and return the structure to the calling
^1da177e4c3f415 Linus Torvalds  2005-04-16  1484  	 * program
^1da177e4c3f415 Linus Torvalds  2005-04-16  1485  	 */
^1da177e4c3f415 Linus Torvalds  2005-04-16  1486  
^1da177e4c3f415 Linus Torvalds  2005-04-16  1487  #ifdef MFCNT
^1da177e4c3f415 Linus Torvalds  2005-04-16  1488  	karg.chip_type = ioc->mfcnt;
^1da177e4c3f415 Linus Torvalds  2005-04-16  1489  #else
^1da177e4c3f415 Linus Torvalds  2005-04-16  1490  	karg.chip_type = ioc->pcidev->device;
^1da177e4c3f415 Linus Torvalds  2005-04-16  1491  #endif
^1da177e4c3f415 Linus Torvalds  2005-04-16 @1492  	strncpy (karg.name, ioc->name, MPT_MAX_NAME);
^1da177e4c3f415 Linus Torvalds  2005-04-16  1493  	karg.name[MPT_MAX_NAME-1]='\0';
^1da177e4c3f415 Linus Torvalds  2005-04-16  1494  	strncpy (karg.product, ioc->prod_name, MPT_PRODUCT_LENGTH);
^1da177e4c3f415 Linus Torvalds  2005-04-16  1495  	karg.product[MPT_PRODUCT_LENGTH-1]='\0';
^1da177e4c3f415 Linus Torvalds  2005-04-16  1496  
^1da177e4c3f415 Linus Torvalds  2005-04-16  1497  	/* Copy the data from kernel memory to user memory
^1da177e4c3f415 Linus Torvalds  2005-04-16  1498  	 */
^1da177e4c3f415 Linus Torvalds  2005-04-16  1499  	if (copy_to_user((char __user *)arg, &karg, sizeof(struct mpt_ioctl_test))) {
29dd3609f2fc70e Eric Moore      2007-09-14  1500  		printk(MYIOC_s_ERR_FMT "%s@%d::mptctl_readtest - "
^1da177e4c3f415 Linus Torvalds  2005-04-16  1501  			"Unable to write out mpt_ioctl_test struct @ %p\n",
29dd3609f2fc70e Eric Moore      2007-09-14  1502  			ioc->name, __FILE__, __LINE__, uarg);
^1da177e4c3f415 Linus Torvalds  2005-04-16  1503  		return -EFAULT;
^1da177e4c3f415 Linus Torvalds  2005-04-16  1504  	}
^1da177e4c3f415 Linus Torvalds  2005-04-16  1505  
^1da177e4c3f415 Linus Torvalds  2005-04-16  1506  	return 0;
^1da177e4c3f415 Linus Torvalds  2005-04-16  1507  }
^1da177e4c3f415 Linus Torvalds  2005-04-16  1508  

:::::: The code at line 1492 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp