Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1228044iog; Sat, 25 Jun 2022 04:20:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uQ7JtrOB17ECJ0giymWXTaxCBPcXoj1qlmsJ2CF11IZrPqqg6ytW0fV1EbBD4dTOUFhxC6 X-Received: by 2002:a17:903:2452:b0:16a:3b58:48fd with SMTP id l18-20020a170903245200b0016a3b5848fdmr3825172pls.67.1656156031380; Sat, 25 Jun 2022 04:20:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656156031; cv=none; d=google.com; s=arc-20160816; b=USqfVYC43Pe5QAjO4gYISbnVoRZl6lI5lhRFhCA4o7AtyA829GZ+QUKRoWV1CbJCiD XKdgAn46+nc/JOE9wPhhCT7NyQaZYJEukRunAKCU6RfxVMRT5PJdYhUXfBCnfsvcEqt/ gl9HT7a4j5uIGW+ByTkFT557wOsIOEorjU3rpv5Wy6WMuGrcyshEHjHLmJW0eIBiV7wn wZxog/Go6R/lBt/2GabvYFKyzDibCufeYSlVDDXxtqNNkxKSVu5kYAzaz8oHyPw/aFMH 0GfGBhqYUW5nQpzOmUDYY1qd9Iu3X/m1yFNT7B7BTYUFtwUEwKSEtfDsGf+EOl0Ba8Rr ERcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GFAOu58A3CNcB7vX9iXelcbaIfakM6abAR3H03ssYCg=; b=F6EpxC/aQ5ZKTsCNpbEg5IWMIAhRVKdchXxk0CCHI7yKvjOXpkeFh/F2hnvSv8I7aO 5hfWPkwhN2skpzMFqj7V7snTJpF1ka6rg38vsVp36IZe2bqbDuiIYh7rjguOtqSlD5HA ajj5FDIxcseI4JSRNaGdJ1NgoHPlULEkLGj8qwKYoYQRT7caWHHBDGZkz3x5jp/fKBtf 6XGlotn9u6t+Ls9Be4rdjOIZDVZ1A+04P31KEZDV6ASYWd8Zd9w3Spsw4yc/CPgmmKHb i7UYEnpT7+fFmYjLFniA6alUxiIkWkEX9HuzSeQODDVPEvCetoP/37oo1GeFPoRFyQXF dexw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="Z5s8sz/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ku17-20020a17090b219100b001eac49d5b1bsi9380121pjb.111.2022.06.25.04.20.19; Sat, 25 Jun 2022 04:20:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="Z5s8sz/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232763AbiFYLCI (ORCPT + 99 others); Sat, 25 Jun 2022 07:02:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232696AbiFYLBq (ORCPT ); Sat, 25 Jun 2022 07:01:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A84133EAC; Sat, 25 Jun 2022 04:01:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 21B5DB80813; Sat, 25 Jun 2022 11:01:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25A07C341C7; Sat, 25 Jun 2022 11:01:42 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="Z5s8sz/p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1656154901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GFAOu58A3CNcB7vX9iXelcbaIfakM6abAR3H03ssYCg=; b=Z5s8sz/p/ZMCBnv7NjJKP3jTX7xvfgGheRSYw83DP2stwaYOr14Yq4ZT8t0BJTYDMtyNq8 cysB5ZHuVjv//A7u9Y950NjvugpoycQF1XnqIrAdvlTrrAnt0llU/ngKLNcmSexqAVS3a6 DWTtC38X5wYU5tVw7qtOsdi0K6/qu5w= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 80eddd6a (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 25 Jun 2022 11:01:41 +0000 (UTC) From: "Jason A. Donenfeld" To: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, Jens Axboe , linux-fsdevel@vger.kernel.org Cc: "Jason A. Donenfeld" , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , dri-devel@lists.freedesktop.org Subject: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag Date: Sat, 25 Jun 2022 13:01:14 +0200 Message-Id: <20220625110115.39956-8-Jason@zx2c4.com> In-Reply-To: <20220625110115.39956-1-Jason@zx2c4.com> References: <20220625110115.39956-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is already set by anon_inode_getfile(), since dma_buf_fops has non-NULL ->llseek, so we don't need to set it here too. Suggested-by: Al Viro Cc: Sumit Semwal Cc: Christian König Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jason A. Donenfeld --- drivers/dma-buf/dma-buf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 32f55640890c..3f08e0b960ec 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) goto err_dmabuf; } - file->f_mode |= FMODE_LSEEK; dmabuf->file = file; mutex_init(&dmabuf->lock); -- 2.35.1