Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e03bd763-a7a8-cb7c-6fc6-6001f2496729@gmail.com>
Date:   Sat, 25 Jun 2022 14:58:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 2/4] platform/surface: Add KIP/POS tablet-mode switch
 driver
Content-Language: en-US
To:     kernel test robot <lkp@intel.com>,
        Hans de Goede <hdegoede@redhat.com>
Cc:     kbuild-all@lists.01.org, Mark Gross <markgross@kernel.org>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220624183642.910893-3-luzmaximilian@gmail.com>
 <202206250711.yKiwV8qa-lkp@intel.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
In-Reply-To: <202206250711.yKiwV8qa-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/25/22 04:59, kernel test robot wrote:
> Hi Maximilian,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on next-20220624]
> [cannot apply to linus/master platform-drivers-x86/for-next v5.19-rc3 v5.19-rc2 v5.19-rc1 v5.19-rc3]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Maximilian-Luz/platform-surface-Add-support-for-tablet-mode-switch-via-Surface-Aggregator-Module/20220625-023751
> base:    2f9cb3d3bd73fc2225d66aa8fcffb632ed3eb235
> config: i386-allyesconfig
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> reproduce (this is a W=1 build):
>          # https://github.com/intel-lab-lkp/linux/commit/190ffdd2194f4c5a5110d6a08f303c47e2da31ba
>          git remote add linux-review https://github.com/intel-lab-lkp/linux
>          git fetch --no-tags linux-review Maximilian-Luz/platform-surface-Add-support-for-tablet-mode-switch-via-Surface-Aggregator-Module/20220625-023751
>          git checkout 190ffdd2194f4c5a5110d6a08f303c47e2da31ba
>          # save the config file
>          mkdir build_dir && cp config build_dir/.config
>          make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>     drivers/platform/surface/surface_aggregator_tabletsw.c: In function 'ssam_pos_get_sources_list':
>>> drivers/platform/surface/surface_aggregator_tabletsw.c:373:32: error: 'SSAM_SSH_TC_POS' undeclared (first use in this function); did you mean 'SSAM_SSH_TC_PoM'?
>       373 |         rqst.target_category = SSAM_SSH_TC_POS;
>           |                                ^~~~~~~~~~~~~~~
>           |                                SSAM_SSH_TC_PoM

Ah, I forgot to mention. This depends on "platform/surface: aggregator:
Reserve more event- and target-categories" which is already in
pdx86/review-hans as commit e244a46a529a. That commit adds the
`SSAM_SSH_TC_POS` symbol, so with it, this patch should compile.

Regards,
Max