Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1315667iog; Sat, 25 Jun 2022 06:20:26 -0700 (PDT) X-Google-Smtp-Source: AGRyM1th7Y5H4QPJrez66gsGWzCBgRYoOjErA605fVu7N/GL/KmBkSSmHRekwj2XdHv8QYVTrNT1 X-Received: by 2002:a17:907:1c11:b0:726:851e:179e with SMTP id nc17-20020a1709071c1100b00726851e179emr1632955ejc.39.1656163226734; Sat, 25 Jun 2022 06:20:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656163226; cv=none; d=google.com; s=arc-20160816; b=muEVaEsWgJL3jaf/1i8bvExbw2BQDoBEjiCegdxz2fzbk7a2pZBd2Fg+HXWs+D2Xv0 4/YEwbcEnTHZ/i4s+0Bn7mii17i8ZB0AUO4nzdxgLew6U5rH+DOq9qGkZ2kLCYV2cg5x 7JXzplYN60VEPuB0Wsmhoht8FXlI0UaRziNfxxZ3OdBQjy8nhhRA3cgJ5YvcrNjxsGqz m4rFTDWVXUTloH+YMx/7rZdPy+EkelFKKhibzzWsEGTPx96n/lIX6cs3sMeyBQ3JyrhH K2M3bQzciGhVvAu+NUt9temtTwOiFQ2ImADZsRxxJF6AXYgLGYurQLSWMbYIyHcsMtZO u7nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=93qtpHursKkhvUOq6K8VwNXS0E+xqVdrKnw6Iy3jKqU=; b=CmKjbLxp12PCyBEh11USpfAZarLQCnhCDA2eIGOUOx5UTud9syC2cKt9KGKdbUxJnL +E7y4iqkijKFgMiNGveTo9YcfvUHhkPYigE/+1jrZpbhozrOG5ME1jFFMdykzrb/2EZN FutqPnZKTukxhD4uTGS2CgEoyz4EDJa2xsZYKDz1ShdTIbqpwhOnUWr5upq1MAqT6Uz8 jYvcqChCNyC24v2QtUSk643+mIsNPkFQ06l7KUKSDDwb54LP9faraeS+GhxJfyLYRMhq J97oXlQ8wWyPP8moFPCyfa9LUDv16OAnFeOezaHz5q/xjOXrjdl3qi2V/3dhCghXIWBr ZIUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JftxZ00V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go6-20020a1709070d8600b007262d1eebf5si6228174ejc.671.2022.06.25.06.20.01; Sat, 25 Jun 2022 06:20:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JftxZ00V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232963AbiFYM4u (ORCPT + 99 others); Sat, 25 Jun 2022 08:56:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232950AbiFYM4q (ORCPT ); Sat, 25 Jun 2022 08:56:46 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66F7D1836D for ; Sat, 25 Jun 2022 05:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656161805; x=1687697805; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ln3n9F0ShlVuPAtczPL0XqN7vo4FAVJWYWhIOXlcAvo=; b=JftxZ00V2DWnM9+NwEkhKBe93JCiKoI9ERJ7m96uIXaTGPAN/q2zxHFw yt0LzbaZq7w0Yv/U2Zr51e/xMiEcKNoFoVXy/PdPq8vD8BA+CgjiB41y6 pkOpN5eyJJuW0JVZU31N71WIEmgsTLycZFLfSN8sQpVliyhd7nel7f2cj cuLAhAV+TbbsEJEpmbTVk9Y28q/mMq3hqTH5VYrFcaLhCRR5C05cRZJJN s8ktjLDOwW8qIiWxn3cDobN0wjzeF5L1WYOfpFbZJ20a6L0urDpfQl/Mx Vu0tZaBvRsfMTttFGlhva9SFG+fPrw2CmBDKDrWIWhMqmIWksGb5npidw Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10388"; a="278727999" X-IronPort-AV: E=Sophos;i="5.92,222,1650956400"; d="scan'208";a="278727999" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2022 05:56:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,222,1650956400"; d="scan'208";a="586890402" Received: from allen-box.sh.intel.com ([10.239.159.48]) by orsmga007.jf.intel.com with ESMTP; 25 Jun 2022 05:56:42 -0700 From: Lu Baolu To: Joerg Roedel , Steve Wahl , Kevin Tian Cc: David Woodhouse , Jerry Snitselaar , Mike Travis , Dimitri Sivanich , Russ Anderson , iommu@lists.linux.dev, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Lu Baolu Subject: [PATCH v1 5/6] iommu/vt-d: Remove global g_iommus array Date: Sat, 25 Jun 2022 20:52:03 +0800 Message-Id: <20220625125204.2199437-6-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220625125204.2199437-1-baolu.lu@linux.intel.com> References: <20220625125204.2199437-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The g_iommus is not used anywhere. Remove it to avoid dead code. Signed-off-by: Lu Baolu --- drivers/iommu/intel/iommu.c | 42 ------------------------------------- 1 file changed, 42 deletions(-) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index f6d7055cffd7..9a284394b2c5 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -126,9 +126,6 @@ static inline unsigned long virt_to_dma_pfn(void *p) return page_to_dma_pfn(virt_to_page(p)); } -/* global iommu list, set NULL for ignored DMAR units */ -static struct intel_iommu **g_iommus; - static void __init check_tylersburg_isoch(void); static int rwbf_quirk; @@ -287,9 +284,6 @@ static LIST_HEAD(dmar_satc_units); #define for_each_rmrr_units(rmrr) \ list_for_each_entry(rmrr, &dmar_rmrr_units, list) -/* bitmap for indexing intel_iommus */ -static int g_num_of_iommus; - static void dmar_remove_one_dev_info(struct device *dev); int dmar_disabled = !IS_ENABLED(CONFIG_INTEL_IOMMU_DEFAULT_ON); @@ -1694,7 +1688,6 @@ static void free_dmar_iommu(struct intel_iommu *iommu) iommu->domain_ids = NULL; } - g_iommus[iommu->seq_id] = NULL; iommu->flags &= ~VTD_FLAG_IOMMU_PROBED; /* free context mapping */ @@ -2899,36 +2892,6 @@ static int __init init_dmars(void) struct intel_iommu *iommu; int ret; - /* - * for each drhd - * allocate root - * initialize and program root entry to not present - * endfor - */ - for_each_drhd_unit(drhd) { - /* - * lock not needed as this is only incremented in the single - * threaded kernel __init code path all other access are read - * only - */ - if (g_num_of_iommus < DMAR_UNITS_SUPPORTED) { - g_num_of_iommus++; - continue; - } - pr_err_once("Exceeded %d IOMMUs\n", DMAR_UNITS_SUPPORTED); - } - - /* Preallocate enough resources for IOMMU hot-addition */ - if (g_num_of_iommus < DMAR_UNITS_SUPPORTED) - g_num_of_iommus = DMAR_UNITS_SUPPORTED; - - g_iommus = kcalloc(g_num_of_iommus, sizeof(struct intel_iommu *), - GFP_KERNEL); - if (!g_iommus) { - ret = -ENOMEM; - goto error; - } - ret = intel_cap_audit(CAP_AUDIT_STATIC_DMAR, NULL); if (ret) goto free_iommu; @@ -2951,7 +2914,6 @@ static int __init init_dmars(void) intel_pasid_max_id); } - g_iommus[iommu->seq_id] = iommu; iommu->flags |= VTD_FLAG_IOMMU_PROBED; intel_iommu_init_qi(iommu); @@ -3079,9 +3041,6 @@ static int __init init_dmars(void) free_dmar_iommu(iommu); } - kfree(g_iommus); - -error: return ret; } @@ -3488,7 +3447,6 @@ static int intel_iommu_add(struct dmar_drhd_unit *dmaru) if (iommu->gcmd & DMA_GCMD_TE) iommu_disable_translation(iommu); - g_iommus[iommu->seq_id] = iommu; iommu->flags |= VTD_FLAG_IOMMU_PROBED; ret = iommu_init_domains(iommu); if (ret == 0) -- 2.25.1