Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 25 Jun 2022 22:12:32 +0200
From:   Lukas Wunner <lukas@wunner.de>
To:     Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     linux-serial@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        linux-kernel@vger.kernel.org,
        Lino Sanfilippo <LinoSanfilippo@gmx.de>
Subject: Re: [PATCH 22/36] serial: Sanitize rs485_struct
Message-ID: <20220625201232.GA17597@wunner.de>
References: <20220606100433.13793-1-ilpo.jarvinen@linux.intel.com>
 <20220606100433.13793-23-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220606100433.13793-23-ilpo.jarvinen@linux.intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Mon, Jun 06, 2022 at 01:04:19PM +0300, Ilpo J?rvinen wrote:
> -	if (rs485->delay_rts_before_send > RS485_MAX_RTS_DELAY) {
> +	if (!port->rs485_supported->delay_rts_before_send) {
> +		if (rs485->delay_rts_before_send) {
> +			dev_warn_ratelimited(port->dev,
> +				"%s (%d): RTS delay before sending not supported\n",
> +				port->name, port->line);
> +		}
> +		rs485->delay_rts_before_send = 0;
> +	} else if (rs485->delay_rts_before_send > RS485_MAX_RTS_DELAY) {
>  		rs485->delay_rts_before_send = RS485_MAX_RTS_DELAY;
>  		dev_warn_ratelimited(port->dev,
>  			"%s (%d): RTS delay before sending clamped to %u ms\n",
>  			port->name, port->line, rs485->delay_rts_before_send);
>  	}

This series seems to set rs485_supported->delay_rts_before_send to 1
in all drivers to indicate that a delay is supported.

It would probably be smarter to define it as a maximum, i.e. drivers
declare the supported maximum delay in their rs485_supported struct
and the core can use that to clamp the value.  Initially, all drivers
may use RS485_MAX_RTS_DELAY.  Some chips only support specific delays
(multiples of the UART clock or baud clock).  We can amend their
drivers later according to their capabilities.

Thanks,

Lukas