Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220615104921.1390138-1-patrick.rudolph@9elements.com> <20220615104921.1390138-3-patrick.rudolph@9elements.com>
In-Reply-To: <20220615104921.1390138-3-patrick.rudolph@9elements.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Sun, 26 Jun 2022 01:08:53 +0200
Message-ID: <CACRpkdakd1T9FFfjbSpLnCmOQM-HVLy+UTJBKkpphyDVmZt6yg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] pinctrl: Add Cypress cy8c95x0 support
To:     Patrick Rudolph <patrick.rudolph@9elements.com>
Cc:     Naresh Solanki <naresh.solanki@9elements.com>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jun 15, 2022 at 12:50 PM Patrick Rudolph
<patrick.rudolph@9elements.com> wrote:

> Add support for cypress I2C GPIO expanders cy8c9520, cy8c9540 and
> cy8c9560. The GPIO expanders feature a PWM mode, thus add it as
> pinctrl driver.
>
> The chip features multiple drive modes for each pin when configured
> as output and multiple bias settings when configured as input.
>
> Tested all three components and verified that all functionality
> is fully working.
>
> Datasheet: https://www.cypress.com/file/37971/download
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>

Looks good to me, I see there are still some comments on the bindings,
once that is fixed this is good to go.

Yours,
Linus Walleij