Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f65fd4fb-675a-3f9e-accb-77db9ad7d551@suse.com>
Date:   Sun, 26 Jun 2022 07:03:55 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] btrfs: Convert zlib_compress_pages() to use
 kmap_local_page()
Content-Language: en-US
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>,
        Nick Terrell <terrelln@fb.com>,
        Chris Down <chris@chrisdown.name>,
        Filipe Manana <fdmanana@suse.com>,
        Nikolay Borisov <nborisov@suse.com>,
        Gabriel Niebler <gniebler@suse.com>,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Ira Weiny <ira.weiny@intel.com>
References: <20220618092752.25153-1-fmdefrancesco@gmail.com>
 <3110135.5fSG56mABF@opensuse>
From:   Qu Wenruo <wqu@suse.com>
In-Reply-To: <3110135.5fSG56mABF@opensuse>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGtwUmdaL2VaMU5MVEprY2hvNHd0a0dIM0pUb0lkc2w5NUV1L21ZZ1B2Umxr?=
 =?utf-8?B?bTdKUnZtSElBMUZvRU5RajY4bXBSSk9Yc29pbXVvMDFqSzNNcnNzWHRtOGhG?=
 =?utf-8?B?RVlrNnV1MzdKWkhkUzJxZDhNZGczZTdjejFMbml1QVNNdDVqUXBpTm5VR09W?=
 =?utf-8?B?cEs2N2hhelp5enZSZzVvV3o2am9iNkNNdEVtTHMvTHFlN2ZTTjUxbW83NHcy?=
 =?utf-8?B?VGdBN2sxUEx2dzdnNEdQVm11MjZvNTJRVkVXU0ErQnYzeDNzejJoRUVMaFJN?=
 =?utf-8?B?Tm5LaFBKME5YZERHMWpCZ24vRG9pTlQ1aTEycThNS29Ga0hWbFkwaExjYzZB?=
 =?utf-8?B?L29vWXU4dTAxUC9BYzZDQ3E4bHRCN2szZ2xGNDJKeEZSSngwYnhnODNqTlpm?=
 =?utf-8?B?U3RUTjhvRjZid2k5eXFnc0Uzd3dkdlduSWFWTmhXUjFzY3FuOWhJS2xxL3F2?=
 =?utf-8?B?VXE2MkhMTFVoZ0pSWXIyTVFYK2NqYlZ2UTRkYUxBeUpUc2d6UXVBR3FjZnBB?=
 =?utf-8?B?dW5VNEZYMWRYOE83Z2JjQVM0NTFvU2UxcFlBSTIxWVo5UUJ6MzJsMEJKRnNx?=
 =?utf-8?B?ZUVTbzJvQVRjUnk2bElLUTg0UFdXUTkyK1F6aFJTUW1mZ3c2cUtNd1JnQXBB?=
 =?utf-8?B?TERMNENqZStsZFdsSzNaOW1ZdDdvVFZWTkdRWEtVVXdLUVk2Ulh1YnRXYlMz?=
 =?utf-8?B?Y1dvRDlMd3Y3UDA3YU9IUEJ0UzNaWlpSN09JU1l2QStBTlpUQXZUQXROUUx1?=
 =?utf-8?B?bGVtUmtMUnFkTDF6Y0R1YjhNQXUzQ2w3S3M1OExGdWdyaGxPQkNCVWZvS2FD?=
 =?utf-8?B?RlkrNEtCZGt2TzN2aktRSkE3WldsbXhVd1ltUWtzV09DRm9vL0RVbXJZOEsy?=
 =?utf-8?B?N25iNFlRc0d3L0tNTW9UdVYzQkxGTmhydUhseUMwdkNMcDFNcWt0ZFhPaGxi?=
 =?utf-8?B?ZmtjeGpzWHhLR2JjNU9pQlBXYkFIMGVHNTBYMFNEOTdVVmdqSlBFS3JXQmV0?=
 =?utf-8?B?cU1xc3V6RHBJRG5VMTVPMkhiQ0dnS1lRZDNpWlRadFpRd1M0TXBxQWI1UHYw?=
 =?utf-8?B?Z1M2ZHN6bUY5ZHIyY2UrMmhiMThoQk1FZEV0aGlJeWF3TXptTFFVUDBxWDcw?=
 =?utf-8?B?d0k0TmRlM28zNndrTTVsekE4SjFyZmtVd2JNcVBiY3pCSnZlQzZrcE4xZkVQ?=
 =?utf-8?B?Z0YyaTR4emxXNmR1emFEOUtpNW15SWpvYTJkSDF3dHcrN2puM2RkQThIblZI?=
 =?utf-8?B?WCtWR0NBMHlpYmZIcERtZmR0L1kyQUZsSVBWbkFWT2hKRnlyTklab2ZtQVdz?=
 =?utf-8?B?MEVXTE1KcGhuZHNBUVRiN1lMbjBRa241V1puMEZ2cVl3ZWxmUGRnZ3VTVlFx?=
 =?utf-8?B?eko3N0pCQXRTM1hSZ2xhaHJQeVFJbVlFb2RiRS9zSkhZQ2cwSlUyVnpLUFlT?=
 =?utf-8?B?US83anpMMXVNenpBb1FzNElhZzFVRHV6Y2FMUXRMSWdGU0xiT3ZBZHU0Ly9y?=
 =?utf-8?B?MXZ0R1RGME1kUGp0aG5GZ2hPVXNUek9WWmxsN0dJU2dQaDNpRE5DR2ZKNEhN?=
 =?utf-8?B?aTZQU1RKamtuZS9Jbk5qMGdFMUt4SzNYOGYxbzVqK3JzS2VyS01yS0VXWnBJ?=
 =?utf-8?B?ckJjYVJyb1BnbzRKZkdlWUhIcTJXVUg0Q0cwYTFXd2JpNDh4ZUtzVm5sNEVU?=
 =?utf-8?B?UVhIMENlb2d6RFZzZzNJYXZZWjlqUi9JYUoxOTRUUUJtSUNQaVpVZ3NVWFNP?=
 =?utf-8?B?enFXUVdaR0xCc2kvM280Wi94STR5RUsrSU04aDRNdklrajg2djJ4NDVKZFBq?=
 =?utf-8?B?d3htbXlqQjV0NWljaERwWE9CZzVNb1cvWUZOUkdsc2NybFVZaEtMTXlhK0VI?=
 =?utf-8?B?clFyaU0ybDMvNWFvMFIyUDVFSU1NL201MGNlK1hqVU1oNGZXQSszV2lyb0lI?=
 =?utf-8?B?MkhRenRtSWtBaFd5OWtyTDFiWnhDeGVzdjhjTDZFNVFFMG1wam5UTXdqSVg0?=
 =?utf-8?B?eTAwUDU3d0lmSmlIc2VZVjcxdDE5R3Zhb3Nvd0JTWlFXOTBXbS9nOHJPT1F1?=
 =?utf-8?B?ai9ISVRUTzc3dVZJUCtOTWtQNFVFa1pONmY4VDAyL0VmNEp3VWg2WFV1emZU?=
 =?utf-8?B?bXFWL1Y3M1ZhN2tBMldMcDJ4bHJneWpwU2hpWVN2ak1jblhxUncybTBCeWNi?=
 =?utf-8?Q?4DlTWIHBJ+QU0a60LCZOlb8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67bb478b-00ab-44fd-4a53-08da56ff0146
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8465.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2022 23:04:06.5785
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DgEb6OvfmGGRjwppS5beiPK9sHQ+3W3w3tgiIKi7pxM8PWseJOkAGvmcb39inkqz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6884
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022/6/25 22:41, Fabio M. De Francesco wrote:
> On sabato 18 giugno 2022 11:27:52 CEST Fabio M. De Francesco wrote:
>> The use of kmap() is being deprecated in favor of kmap_local_page(). With
>> kmap_local_page(), the mapping is per thread, CPU local and not globally
>> visible.
>>
>> Therefore, use kmap_local_page() / kunmap_local() in
> zlib_compress_pages()
>> because in this function the mappings are per thread and are not visible
>> in other contexts.
>>
>> Tested with xfstests on QEMU + KVM 32-bit VM with 4GB of RAM and
>> HIGHMEM64G enabled. This patch passes 26/26 tests of group "compress".
>>
>> Cc: Qu Wenruo <wqu@suse.com>
>> Suggested-by: Ira Weiny <ira.weiny@intel.com>
>> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>> ---
>>
>> This patch builds only on top of
>> "[PATCH] btrfs: zlib: refactor how we prepare the input buffer" by Qu
> Wenruo".
>> https://lore.kernel.org/linux-btrfs/
> d0bfc791b5509df7b9ad44e41ada197d1b3149b3.1655519730.git.wqu@suse.com/
>>
> 
> I've seen that Qu sent a v2 of the above patch. However David thinks that
> it is better not to map pages allocated in zlib.c for output (out_page)
> since they cannot come from highmem because of "alloc_page(GFP_NOFS);".
> 
> @David:
> 
> I suppose that, since it builds _only_ on top of the refactor submitted by
> Qu, I'll have to wait and see what you decide.
> 
> If you don't want kmap_local_page() and prefer using page_address() on
> "out_page", please drop this patch and let me know, so that I can send a
> new patch which will be in accordance to your preference.

And that would also make the convert much easier for kmap_local_page() 
of input pages.

I'll hold the refactor patch after all the kmap code is converted.

Thanks,
Qu

> 
> Thanks,
> 
> Fabio
> 
>