Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3a6ca6a4af7773f68f29b443fa5a4e106727e83.camel@icenowy.me>
Subject: Re: [RESEND PATCH] rtc: sun6i: add support for R329 RTC
From:   Icenowy Zheng <uwu@icenowy.me>
To:     Samuel Holland <samuel@sholland.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-rtc@vger.kernel.org, linux-sunxi@lists.linux.dev
Date:   Sun, 26 Jun 2022 12:31:33 +0800
In-Reply-To: <20220626042756.58961-1-samuel@sholland.org>
References: <20220626042756.58961-1-samuel@sholland.org>
Organization: Anthon Open-Source Community
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

=E5=9C=A8 2022-06-25=E6=98=9F=E6=9C=9F=E5=85=AD=E7=9A=84 23:27 -0500=EF=BC=
=8CSamuel Holland=E5=86=99=E9=81=93=EF=BC=9A
> From: Icenowy Zheng <icenowy@aosc.io>
>=20
> Allwinner R329 has a RTC with a similar time storage with H616 but a
> slightly different clock part.
>=20
> As we have already handled the R329 RTC clocks in the CCU driver, add
> a
> compatible string to RTC driver to allow probing of the RTC.
>=20
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> Resending this patch separately from Icenowy's R329 series[1] because
> it
> is also needed for D1 (which has R329 as its fallback compatible[2]),
> so
> I would like to get it in to 5.20.

Thanks!

BTW when will you put D1 DTs into kernel?

>=20
> [1]:
> https://lore.kernel.org/lkml/BYAPR20MB2472C608678F3FAEDA7B7541BCF79@BYAPR=
20MB2472.namprd20.prod.outlook.com/
> [2]:
> https://lore.kernel.org/lkml/20220203021736.13434-3-samuel@sholland.org/
>=20
> =C2=A0drivers/rtc/rtc-sun6i.c | 2 ++
> =C2=A01 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 57540727ce1c..ed5516089e9a 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -875,6 +875,8 @@ static const struct of_device_id
> sun6i_rtc_dt_ids[] =3D {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ .compatible =3D "allwin=
ner,sun50i-h6-rtc" },
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ .compatible =3D "allwin=
ner,sun50i-h616-rtc",
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0.data =3D (void *)RTC_LINEAR_DAY },
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ .compatible =3D "allwinner,s=
un50i-r329-rtc",
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0.data =3D (void *)RTC_LINEAR_DAY },
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ /* sentinel */ },
> =C2=A0};
> =C2=A0MODULE_DEVICE_TABLE(of, sun6i_rtc_dt_ids);