Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 26 Jun 2022 08:19:36 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Michael =?iso-8859-1?Q?Niew=F6hner?= <linux@mniewoehner.de>
Cc:     LinoSanfilippo@gmx.de, James.Bottomley@hansenpartnership.com,
        peterhuewe@gmx.de, jgg@ziepe.ca, stefanb@linux.vnet.ibm.com,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        l.sanfilippo@kunbus.com, lukas@wunner.de, p.rosenberger@kunbus.com
Subject: Re: [PATCH v5 10/10] tpm, tpm_tis: Enable interrupt test
Message-ID: <YrfsP3/Da6+3dpbg@kernel.org>
References: <20220610110846.8307-1-LinoSanfilippo@gmx.de>
 <20220610110846.8307-11-LinoSanfilippo@gmx.de>
 <YqokW/cNLrrsZ2ib@iki.fi>
 <75124ab23f2c845d8f683d7e3123de3ccdb07ad0.camel@mniewoehner.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <75124ab23f2c845d8f683d7e3123de3ccdb07ad0.camel@mniewoehner.de>
Precedence: bulk

On Thu, Jun 16, 2022 at 03:04:30PM +0200, Michael Niew?hner wrote:
> On Wed, 2022-06-15 at 21:26 +0300, Jarkko Sakkinen wrote:
> > On Fri, Jun 10, 2022 at 01:08:46PM +0200, LinoSanfilippo@gmx.de?wrote:
> > > From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> > > 
> > > The test for interrupts in tpm_tis_send() is skipped if the flag
> > > TPM_CHIP_FLAG_IRQ is not set. Since the current code never sets the flag
> > > initially the test is never executed.
> > > 
> > > Fix this by setting the flag in tpm_tis_gen_interrupt() right after
> > > interrupts have been enabled.
> > > 
> > > Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> > > ---
> > > ?drivers/char/tpm/tpm_tis_core.c | 5 +++++
> > > ?1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/drivers/char/tpm/tpm_tis_core.c
> > > b/drivers/char/tpm/tpm_tis_core.c
> > > index e5edf745fb23..be229c173f10 100644
> > > --- a/drivers/char/tpm/tpm_tis_core.c
> > > +++ b/drivers/char/tpm/tpm_tis_core.c
> > > @@ -774,11 +774,16 @@ static int tpm_tis_gen_interrupt(struct tpm_chip
> > > *chip)
> > > ????????if (ret < 0)
> > > ????????????????return ret;
> > > ?
> > > +???????chip->flags |= TPM_CHIP_FLAG_IRQ;
> > > +
> > > ????????if (chip->flags & TPM_CHIP_FLAG_TPM2)
> > > ????????????????ret = tpm2_get_tpm_pt(chip, 0x100, &cap2, desc);
> > > ????????else
> > > ????????????????ret = tpm1_getcap(chip, TPM_CAP_PROP_TIS_TIMEOUT, &cap,
> > > desc, 0);
> > > ?
> > > +???????if (ret)
> > > +???????????????chip->flags &= ~TPM_CHIP_FLAG_IRQ;
> > > +
> > > ????????release_locality(chip, 0);
> > > ?
> > > ????????return ret;
> > > -- 
> > > 2.36.1
> > > 
> > 
> > James, do you have a chance to test this on your side? Thanks.
> > 
> > BR, Jarkko
> 
> Tested-by: Michael Niew?hner <linux@mniewoehner.de>

Thank you.

BR, Jarkko