Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 22/36] serial: Sanitize rs485_struct
To:     Lukas Wunner <lukas@wunner.de>,
        =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     linux-serial@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org
References: <20220606100433.13793-1-ilpo.jarvinen@linux.intel.com>
 <20220606100433.13793-23-ilpo.jarvinen@linux.intel.com>
 <20220625201232.GA17597@wunner.de>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <d6f6cbb9-e8d9-d69c-d722-231096464484@gmx.de>
Date:   Sun, 26 Jun 2022 14:39:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220625201232.GA17597@wunner.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 25.06.22 at 22:12, Lukas Wunner wrote:
> On Mon, Jun 06, 2022 at 01:04:19PM +0300, Ilpo J=C3=A4rvinen wrote:
>> -	if (rs485->delay_rts_before_send > RS485_MAX_RTS_DELAY) {
>> +	if (!port->rs485_supported->delay_rts_before_send) {
>> +		if (rs485->delay_rts_before_send) {
>> +			dev_warn_ratelimited(port->dev,
>> +				"%s (%d): RTS delay before sending not supported\n",
>> +				port->name, port->line);
>> +		}
>> +		rs485->delay_rts_before_send =3D 0;
>> +	} else if (rs485->delay_rts_before_send > RS485_MAX_RTS_DELAY) {
>>  		rs485->delay_rts_before_send =3D RS485_MAX_RTS_DELAY;
>>  		dev_warn_ratelimited(port->dev,
>>  			"%s (%d): RTS delay before sending clamped to %u ms\n",
>>  			port->name, port->line, rs485->delay_rts_before_send);
>>  	}
>
> This series seems to set rs485_supported->delay_rts_before_send to 1
> in all drivers to indicate that a delay is supported.
>
> It would probably be smarter to define it as a maximum, i.e. drivers
> declare the supported maximum delay in their rs485_supported struct
> and the core can use that to clamp the value.  Initially, all drivers
> may use RS485_MAX_RTS_DELAY.  Some chips only support specific delays
> (multiples of the UART clock or baud clock).  We can amend their
> drivers later according to their capabilities.

Agreed.

Regards,
Lino