Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 26 Jun 2022 08:30:19 -0400
From:   Joe Korty <joe.korty@concurrent-rt.com>
To:     Mark Gross <markgross@kernel.org>
Cc:     "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux RT users <linux-rt-users@vger.kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RT BUG] Mismatched get_uid/free_uid usage in signals in some
 rts (2nd try)
Message-ID: <20220626123019.GA51149@zipoli.concurrent-rt.com>
Reply-To: Joe Korty <joe.korty@concurrent-rt.com>
References: <VI1PR09MB358214376379A2D6B024A689A0B39@VI1PR09MB3582.eurprd09.prod.outlook.com>
 <YrXtH1z2JSmwLS7W@T470>
 <20220624184431.GA4386@zipoli.concurrent-rt.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220624184431.GA4386@zipoli.concurrent-rt.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Pq4cdp744fuFMNUEXGRcPWbiRTdQxbnEJ/u/UoMlkjZOq2YcSZUXeHBi4yMI?=
 =?us-ascii?Q?986JrJwqnTMra1MmUCN2mQ+LZimmJHW5U6802meFLlqy+FyQFGZ73SUyTxwA?=
 =?us-ascii?Q?gmunvoMB5EyCbVwNZoxsHdujbAqWuVT7MYpn+xKLPjqn1xv2+0qgJuPReFNI?=
 =?us-ascii?Q?Vv+pK/u4lOHMHn65RFGsFKP8rJpgR8mSl886gog9IWj8+SvfmF9SCOE014Oo?=
 =?us-ascii?Q?T0+fMBnjuLnYFqE3Xadhv453i7ioKN7sE/S2x+1VpFGfHKMsLngN7l3uEXpf?=
 =?us-ascii?Q?FWzasV6tAaK/Gg9K1JD2Bp6zV61fh+xmcmjXrnBp3enVin//g8Sp20ydq6QB?=
 =?us-ascii?Q?qp4zQTUwamZn93g4xfjTyApBte38YjTSuTrNC3/gir4rJd/42GygwNK/k/6e?=
 =?us-ascii?Q?p49U3nXzi1RibFBGxGk5PhdaJxK5sORRtPKfozum97hmRDxJ7TtbCMm8xy9V?=
 =?us-ascii?Q?oVMhVbrJE37twfYjtXzWwHPTo6OT4CLOl17jAJLF9oXjrny8GBiCvNcMqwsw?=
 =?us-ascii?Q?7QWBVA184JxdLO90jVtqTI3ijEEi3pBJC0JW1dt65BqS4uohMM9suvYAHzMj?=
 =?us-ascii?Q?LrwDygSDX6LuTXFgLRHqO5vdr119GYsWhLlzdQlILPMNMgEtSXQ98HiWsCSB?=
 =?us-ascii?Q?rh5hOUs+95kVRW659a0N3UYEil4+1KDeQhnURnoPBpa79JzSB8wOJEqWktwS?=
 =?us-ascii?Q?W2J35nelSHhdF/3TMHyvbpEgFDYx7zqi9+WmuWsNuqQTHWzt0zpttLLg8DVl?=
 =?us-ascii?Q?26KHuSIzw1GpghTQDPoDPDAVhsJpk3sdYsleweFJKshavxcwPD2CzSGRlIEu?=
 =?us-ascii?Q?Aavp1nL4L0wPQLnYvSS72lvfCJ5yDHcK9gbpuhIsgKd624MW8AbTXAsfV+p1?=
 =?us-ascii?Q?0WvXi/fsIvUnjnQhud4teEP3/kdvr7lFgdvtliw0gUE//iv6y8yAK9bemt2W?=
 =?us-ascii?Q?IgT6n6qVfNBG/+0RJX4LGxgFhEHJrvCRQnCcpQgwRXrATxNsc1///h19dDJz?=
 =?us-ascii?Q?mLxVAmHuGm0mA+qk3HoA546aDMZKFrVUKpZQyS8QCbLaCOar1uei+dk8E1Rt?=
 =?us-ascii?Q?Va6XbC2OqCRl9BpwpVWlqHdj51oAi/huQgXW0chKnEqdm4g17YRx9yOcOOq8?=
 =?us-ascii?Q?v1omFy7TIpfiYRHqx10oVXpveIFrY4/3ovqqXBQpqeDMirdxXZDJxnzCymY+?=
 =?us-ascii?Q?ii8c2IlDpdAHD7AU2xPM2aU3bi9cfqm2EjOzQEwg/J5LNx6lACRDTwBrlsm3?=
 =?us-ascii?Q?onJ8REv0VxyAU/rf7Ck1D6RhhpucRYXwPF4WsCqHsGPiNZwkOyVZENmzLJ1x?=
 =?us-ascii?Q?l1kCad1vovm/eCrJkiEu6niRx1P0jMwExHOUDF5sO9+ilS+u9j+pK0Gku1QD?=
 =?us-ascii?Q?gZ4tzV3s7DSAVFpxAKooBGb2LKFLI5wzrGLnasPpSRbQ6Wva27KL69csoV4a?=
 =?us-ascii?Q?okSuKzTWnDTrC+srAahMe16wFhKctxUs1/qSETSQtooZeUSjszjiHypfjX6f?=
 =?us-ascii?Q?uGOJl21hn+RB5xozp6/k28ShTnG/YVKScvASXMyJhsDc/Uz9Nkuy7RFvlksu?=
 =?us-ascii?Q?QUg2ZKZ2tV70aYnOzWk9AiIOhAZxUMnSVp9lrsIx1/Y6AvwSZg8ptFHmQljs?=
 =?us-ascii?Q?bQ=3D=3D?=
X-OriginatorOrg: concurrent-rt.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eaac065e-7721-4017-5561-08da576fa577
X-MS-Exchange-CrossTenant-AuthSource: VI1PR09MB3582.eurprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2022 12:30:25.7906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 6cce74a3-3975-45e0-9893-b072988b30b6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vU0VmVSV7kl+f9jTQ4dMlvUkgQCkPzTQNNKkidNmOk1g4K9l0XvyqdhCMO2PyKb4wsW1IVlP4r6SCaBAGeFPgaHAlYQNKW5923NRLc1zCQk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0902MB1972
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 24, 2022 at 02:44:31PM -0400, Joe Korty wrote:
> [ Fixed incorrect linux-rt-users email address in CC ]
> 
> On Fri, Jun 24, 2022 at 09:58:07AM -0700, Mark Gross wrote:
> > On Tue, Jun 21, 2022 at 03:16:39PM +0000, Joe Korty wrote:
> > > Mismatched get_uid/free_uid usage in signals in 4.9.312-rt193
> > >
> > >      [  First attempt using mutt did not show up on the mailing lists.
> > >         Trying again with office365 Outlook.   Also added the 4.9-rt
> > >         maintainers. ]
> > >
> > > The 4.19-rt patch,
> > >
> > >    0329-signal-Prevent-double-free-of-user-struct.patch
> > >
> > > needs to be ported to LAG 4.9-rt, as that release now has the Linus commit,
> > What does LAG stand for?
> 
> Hi Mark,
> LAG = Latest and Greatest
> 
> 
> 
> > FWIW the cherry-pick within the RT-stable tree worked without conflict.
> >     (cherry picked from commit a99e09659e6cd4b633c3689f2c3aa5f8a816fe5b)
> > It compiles.
> > See 58a584ee59b2 signal: Prevent double-free of user struct in
> > linux-stable-rt.git/v4.9-rt-next


Hi Mark,
Absent an actual test of your port of a99e09659e6c to 4.9-rt, I just
eye-verified that the change it makes to sigqueue_free_current looks
correct.  In detail,

  matches the same change the Linus patch makes to __sigqueue_free (ie,
  to the routine that sigqueue_free_current is a copy of).

  That the new variable 'up', in sigqueue_free_current, is being used
  in the patch (some variants of this fix do not have 'up'), and that
  variable is present in 4.9's version of sigqueue_free_current.
  
  That atomic_dec_and_test, rather than the refcounting version of that
  some function, is being used (some versions of this patch are refcounted
  instead).
  
Regards,
Joe