Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220621034224.38995-1-samuel@sholland.org> <20220621034224.38995-5-samuel@sholland.org>
In-Reply-To: <20220621034224.38995-5-samuel@sholland.org>
Reply-To: wens@csie.org
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Sun, 26 Jun 2022 21:03:12 +0800
Message-ID: <CAGb2v64Mrn88+w5kCbMn7Z23-UdyrTG-Q2cboPswMj=9z4HgrQ@mail.gmail.com>
Subject: Re: [PATCH v2 4/4] ARM: dts: axp22x/axp809: Add GPIO controller nodes
To:     Samuel Holland <samuel@sholland.org>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 21, 2022 at 11:42 AM Samuel Holland <samuel@sholland.org> wrote:
>
> These PMICs all contain a GPIO controller. Now that the binding is
> documented, wire up the controller in the device tree.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> (no changes since v1)
>
>  arch/arm/boot/dts/axp22x.dtsi | 18 ++++++++++++++++++
>  arch/arm/boot/dts/axp809.dtsi | 19 +++++++++++++++++++
>  2 files changed, 37 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi
> index a020c12b2884..5c233c84be92 100644
> --- a/arch/arm/boot/dts/axp22x.dtsi
> +++ b/arch/arm/boot/dts/axp22x.dtsi
> @@ -67,6 +67,24 @@ battery_power_supply: battery-power {
>                 status = "disabled";
>         };
>
> +       axp_gpio: gpio {
> +               compatible = "x-powers,axp221-gpio";
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +
> +               /omit-if-no-ref/
> +               gpio0_ldo: gpio0-ldo-pin {
> +                       pins = "GPIO0";
> +                       function = "ldo";
> +               };
> +
> +               /omit-if-no-ref/
> +               gpio1_ldo: gpio1-ldo-pin {
> +                       pins = "GPIO1";
> +                       function = "ldo";
> +               };
> +       };
> +

We have

    reg_ldo_io0: ldo-io0 {
            pinctrl-names = "default";
            pinctrl-0 = <&gpio0_ldo>;
            /* Disable by default to avoid conflicts with GPIO */
            ...
    }

in axp81x.dtsi . Should we add it here and for axp803.dtsi as well?

Otherwise,

Reviewed-by: Chen-Yu Tsai <wens@csie.org>