Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2161933iog; Sun, 26 Jun 2022 08:13:43 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uDUiDCKFY66WVbOe24ei/opUETiKU1lelSrQlDsCINOh/6dtzQfo38k5Hea0+psVEbOeO3 X-Received: by 2002:a05:6402:2396:b0:435:775b:b136 with SMTP id j22-20020a056402239600b00435775bb136mr11756169eda.299.1656256422844; Sun, 26 Jun 2022 08:13:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656256422; cv=none; d=google.com; s=arc-20160816; b=BiL8nKU8hpjKp0JatDFR5yOtkW+08ThZS17k5TOFsl3SIKEz3Pu2d37TjhzRC2pKHc m4oN+uymdui/ULGQyfhNDpe3BSmk8j84jzYZnFd2aKdA8zDlHnULG/NdqDOHkbQFBOrl JdeZZvtbJDd3EqEeL/5ecAnZjwZcx0hn541ZcIdgL6y97BY73rDmdW/uAIwo4xyjU8dK dbSg2srSXNu3emfI3Q5RWNd1fw3qcOlQFov1S6OjyakWQrmR0co+KTbwwOnXY1P6scaw 8TJbUHK8n1UZ3wSNQtF7lsTOsz6whCfVsxp+1psAH7kuAoeTNgGN53qUaexVZcANsP+g h3gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-filter; bh=LGPEL3i9mnlk6FgAfOfRBqIGs5jo7TW+YPJ67QMMXIA=; b=J7UG598MCHeCIcZD7Wn+y7VsBjHxaPFu3QcbKSSKJg7GtKU4+yEw5QwhLd6txIARtW oABGD+sre4PkS/YWVQoxa6IHW7O0bxpgQE71wsnFqYU4vnibH6lLpUkapDd60QP1Cm+Y 46B6G2utTjbDksHzPymtAsTe0MNErzGVWWCaukyvf3ptgIJhltFbS3bUUAsexVClguZ9 6jhP5qn+6JMWy6j/tEZYHB+9luTlk9JTL1+kY/Qo7oHPKdmLes2EtZP0eyWfiUjnrMry tujHT7L68zQxwVt2KlqucJ6etiRWce2MCICEgVcVFyz47hscEuPgAa8cBAn0yFZzDyZV 1iig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fr.zoreil.com header.s=v20220413 header.b=BIUVc5AF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wl17-20020a170907311100b006fef872f3c4si8143119ejb.182.2022.06.26.08.13.18; Sun, 26 Jun 2022 08:13:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@fr.zoreil.com header.s=v20220413 header.b=BIUVc5AF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231312AbiFZPI1 (ORCPT + 99 others); Sun, 26 Jun 2022 11:08:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231150AbiFZPIX (ORCPT ); Sun, 26 Jun 2022 11:08:23 -0400 Received: from violet.fr.zoreil.com (violet.fr.zoreil.com [IPv6:2001:4b98:dc0:41:216:3eff:fe56:8398]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93B32B7C4; Sun, 26 Jun 2022 08:08:19 -0700 (PDT) Received: from violet.fr.zoreil.com ([127.0.0.1]) by violet.fr.zoreil.com (8.17.1/8.17.1) with ESMTP id 25QF7g7c557702; Sun, 26 Jun 2022 17:07:42 +0200 DKIM-Filter: OpenDKIM Filter v2.11.0 violet.fr.zoreil.com 25QF7g7c557702 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fr.zoreil.com; s=v20220413; t=1656256063; bh=LGPEL3i9mnlk6FgAfOfRBqIGs5jo7TW+YPJ67QMMXIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BIUVc5AF5YRFb3yPeWm89XIry5JW3ZNWeY1kzxMGDcoIxpa+GNBtXckhgoI+8w/fT 1zNSoT7AhlDKKL1+hJJ9wFYsFVokCC3OED9ewkcWHzMLq9mtOTl6XSS7BmkN+iuLc4 Tw5zK1ax5+kc3BzaPYqljWwhrPK7mxYp4p+lxqZg= Received: (from romieu@localhost) by violet.fr.zoreil.com (8.17.1/8.17.1/Submit) id 25QF7dLd557701; Sun, 26 Jun 2022 17:07:39 +0200 Date: Sun, 26 Jun 2022 17:07:38 +0200 From: Francois Romieu To: Tong Zhang Cc: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Florian Fainelli , Arnd Bergmann , Jason Gunthorpe , Jeff Kirsher , Netdev , open list , Yilun Wu Subject: Re: [PATCH] epic100: fix use after free on rmmod Message-ID: References: <20220623074005.259309-1-ztong0001@gmail.com> <20220624114121.2c95c3aa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tong Zhang : [...] > Looks like drivers/net/ethernet/smsc/epic100.c is renamed from > drivers/net/epic100.c and this bug has been around since the very > initial commit. > What would you suggest ? Remove the fix tag or use > Fix: 1da177e4c3f4 ("Linux-2.6.12-rc2") 'Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")' has already been signed-by or directly used by maintainers, including netdev ones. See: $ git log --grep='^Fixes: 1da177e4c3f4' The patch will require some change for pre-5.9 stable kernels due to 63692803899b563f94bf1b4f821b574eb74316ae "epic100: switch from 'pci_' to 'dma_' API". -- Ueimor