Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2250663iog; Sun, 26 Jun 2022 10:31:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sQjvwD6dQy07dra5NvBwRL70ntOu+2bnsR87j9Wa7JDIfk7Scc8Mn/scJ66WE7WmYJ7MLf X-Received: by 2002:a17:906:4fd3:b0:726:2b29:9fb with SMTP id i19-20020a1709064fd300b007262b2909fbmr8698141ejw.370.1656264709304; Sun, 26 Jun 2022 10:31:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656264709; cv=none; d=google.com; s=arc-20160816; b=zmiFEMWY9UKXEUFg46Zp3xjv0w0dEb7dGl9Ipa1m/avL/OA6BlMCai8iM0bwsTv0/o rzd4Gu8TePQcjTzIK/XpgA3LZR5KjjwI4hLVefbBZ+xEZtDoR+bP6AxwRsICyJRkh/Jr or0DIft9lhSQHvXoMvCDfq1K4FhZjPaX31W5iXsKrmVy+6BN8O22xQPjxDRMtItNuKx4 KWAKOtUH2RydfBV5sEgTK3yCO3D28v7In15rnYeG0XTXHg3uKT9h9iyfwn9IGIqcMBpG uQajcaCCfRvtCOlZrZVKFFMngfC4gIQxtRsiWes19QKWSSTqsKrjJtdjq+IkBgpN9NhP YHtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=2cHA6ydKdEDT7h2hWxxythmCYVdDf8I+oYVdJP/PQ+4=; b=HKVfImh5FsgQbmCJAzzLhlKvIARiYFThvXkD8g9MKhVM/oM2jAJz7QFzIKYA2d4O91 56S9shTlnOVqaDwKhaSVttLb/LfAdSXfQhX8Cnt2mlq48KYBRUz/2O9qdv0VKQ8Go/9b bFq0l0XPOcrGo0SLy6TUBOsZ+3FO8X1JrqAvoo5M8kRmfrZbp2YEsf9KPKFIjKfN11/s aqO11QsWtXzfHOK1hmu2e931nOcjjQtukRiBgDEq5F/fWZcRQkE8MEj3cPkck9OaDoFF x6JpYoA2HMkjKv4Jn6jC/Ds+ddKjDOIj2Xrn+5rFQYTzQo4jI82Lcy5LsCMuXYdjRQa0 5Dcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hs6adm+9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go12-20020a1709070d8c00b007175ffc8ba1si11328867ejc.993.2022.06.26.10.31.23; Sun, 26 Jun 2022 10:31:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hs6adm+9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbiFZRPg (ORCPT + 99 others); Sun, 26 Jun 2022 13:15:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbiFZRPd (ORCPT ); Sun, 26 Jun 2022 13:15:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 520DDE096; Sun, 26 Jun 2022 10:15:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E0B3C60E1F; Sun, 26 Jun 2022 17:15:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC2C9C34114; Sun, 26 Jun 2022 17:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656263731; bh=ludklJ6ApT6pvSgqsgkUagNtgj9WrP6wywWzAV/JXKI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Hs6adm+9siiZkyH8PluMpNfNgoNBeIVZz+2aKj79PVwAVwWk+i/JXHTauJ/u4i4/w oSaq8dZALC7lUuQNELMnCH8BKJcSPpiNYvJRBUg2teSnrIn6SdegPxRW8X2uHuGrcL um8OfWgUP4bHGHH0iNrPN7dZGpYm37HXnhUcHicwpHhjdgt3P0c6uOQGmwVGwl8XYJ 7EePLl5oLyybOI6VSfnR08KxduFvAWBlVc7cYCFz6qo92e2nsqlyBRTR5NkNzRjNDg ELsWgbr1buJvYrn3ROcnp1psekbUZaLbSs3ezwHNiCn6YIRl9Bgc/iQInIdgukMiQE iOuDvvxYggBdA== Message-ID: <959eac09-28ae-da99-f8bd-d4b3d1182988@kernel.org> Date: Sun, 26 Jun 2022 11:15:29 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] ipv6/sit: fix ipip6_tunnel_get_prl when memory allocation fails Content-Language: en-US To: zys.zljxml@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com, eric.dumazet@gmail.com, pabeni@redhat.com, katrinzhou References: <20220625054524.2445867-1-zys.zljxml@gmail.com> From: David Ahern In-Reply-To: <20220625054524.2445867-1-zys.zljxml@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/24/22 11:45 PM, zys.zljxml@gmail.com wrote: > From: katrinzhou > > Fix an illegal copy_to_user() attempt when the system fails to > allocate memory for prl due to a lack of memory. > > Addresses-Coverity: ("Unused value") > Fixes: 300aaeeaab5f ("[IPV6] SIT: Add SIOCGETPRL ioctl to get/dump PRL.") > Signed-off-by: katrinzhou > --- > > Changes in v2: > - Move the position of label "out" > > net/ipv6/sit.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > Reviewed-by: David Ahern