Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2287569iog; Sun, 26 Jun 2022 11:33:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1smKGNuyqGnk+rptC5N/PJFuBRzOIZoyUI7ReLMAdV+HqpJdpCHNmxz/HDbEctTLHi/QrH5 X-Received: by 2002:a17:902:ab87:b0:162:26cf:bf7a with SMTP id f7-20020a170902ab8700b0016226cfbf7amr10048779plr.168.1656268426038; Sun, 26 Jun 2022 11:33:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656268426; cv=none; d=google.com; s=arc-20160816; b=LeUW0ADGA4WJmQIfUQvBD+2AyHJWSI6IlA4+g5ZH/YvckAJivwpJo1PhKQEijYevvC RkoZLB2xTKuR5zefei9V2Hn0cB/mzm82eAEbDpvT5mrJvhsG5b/TjiwY/2WwdFFFFY3C gIk2aADh4ZCc3wfWE6D2LR21Qu1CfybZ46h4ufzCCNnS8CR3CkXdsN+dI+XUrEu8IB99 psQmPcyqbR+6NG4W/OvKyw1JgKw41dEENh/jlND6PRymqmOnSUSfggNpHUWcaZ0tJTuV D4Wwvov3Ew6SnHT5zem7/88S/b2vB/2togAjQng0tLEmq8AlyfsBgKnB6F7d271Nqxx7 vRAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=XAouVpcuNw+xkGv1ro6XQDbRNz/+UookdfvS2DjviFc=; b=vW3OVwUYhd1UwudKSS5Gs10IV5Yhw9NhifAUm1Sihr1f8M4cDXXb9hvSMtwX66BA6w Nx+0bgpvlLsTGw4dy5SRUK+E8Xn+g4BHZTcrt94V3jFX5mEsS+D5pQsWXaagoFI31k/m stgQYODhQHjpj097yUfWu+RTzNmd1zSG2ya8NwcQS2iUumpmRiq/FEX/3z0tb5Mj2gWf hzUspKusIDtte+nmeD9rkGpf5kPn+jflieKWWBHOt0SRjvsWS3yrK58M4hVzrG1D8tmA 8eCk0HaGrIIBxG2o/EcScimSFAAkKC2jJf9f2m6m2DN9g01nFY3TP8cANiiJcFD7A1B+ e2XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=df1WpvNn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i22-20020a056a00225600b005183f5deeebsi9956434pfu.302.2022.06.26.11.33.34; Sun, 26 Jun 2022 11:33:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=df1WpvNn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231587AbiFZS2f (ORCPT + 99 others); Sun, 26 Jun 2022 14:28:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230346AbiFZS2d (ORCPT ); Sun, 26 Jun 2022 14:28:33 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 342C6DFEA for ; Sun, 26 Jun 2022 11:28:32 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id u15so14650543ejc.10 for ; Sun, 26 Jun 2022 11:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=XAouVpcuNw+xkGv1ro6XQDbRNz/+UookdfvS2DjviFc=; b=df1WpvNnsk4sOSrk1LpaKY9Dd6EcxG47fQKxV/1LDriGOhH6eu9cw2a4/YZwccX+nM vNcwqm9MyaR2bhJVqTYIvOwGLFU/8XehY/yR24Fu2+/FN3dWB5VjB8oX4PW/jegmv5cz BS5EapXZx/A1OenJVpKAenOW9ZEUmHsfKUXZzICpSHhB3cWhLQe/1+ybP6oPFxDJbCay 0eLH6Ziym37sYWPccFE5Y5I3DRWLwKxJ16w4fsNpP+1iVyHL7D3x1V0jsNO72qHZGRcp QTu72d7BvOcsK42toxzM48QnPJHm1P8FGFRGccPLio/VBHuuzuI4/GzKI6L6LukFkZEE LvzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XAouVpcuNw+xkGv1ro6XQDbRNz/+UookdfvS2DjviFc=; b=M1EgsogGOA9pwzHPim+tGQ7cwdCd/kRKtCfHRbr6mReEvNaUq2CWXxKFNv1QROiBy5 xjLGqLiF/6nSCORaQpJ7ed12on6BKdT7mSjc9pzwiT8Z/yVKZSLalvNTLCFzVi5TsxbU j5jp+fKeqnxWC5JXP2mgFXw8lHocU6hXp1ZNoU2TDVSqCtqW3CIci4XjHLZfswmLpex0 u7pt4KBMFgXvggMuCG55TAn+ZyK/sqK/bByolDMGrAJhK96MSwHthLqiC1wUGE6xgr2A efeResWWttI+6zn/+KVVvLggCC5JjcwyA9BWvBdehWNpF3eDFOzkRtO7y5V/aX5BfQfU kKDg== X-Gm-Message-State: AJIora9UwoHWTmWUa4DIVlGVo0l1z/nLBSygEeNor4mU1gXWc3n6P5Gl HTuS/WY1n2H432LeKH+zNTwLNg== X-Received: by 2002:a17:906:5d07:b0:722:eac8:29a6 with SMTP id g7-20020a1709065d0700b00722eac829a6mr9072271ejt.89.1656268110735; Sun, 26 Jun 2022 11:28:30 -0700 (PDT) Received: from [192.168.0.243] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id h8-20020a170906260800b00718f4d4f073sm4039818ejc.88.2022.06.26.11.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jun 2022 11:28:30 -0700 (PDT) Message-ID: <7f4ebc9c-6412-9494-ba77-cc625b34d197@linaro.org> Date: Sun, 26 Jun 2022 20:28:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 3/3] dt-bindings: firmware: convert Qualcomm SCM binding to the yaml Content-Language: en-US To: David Heidelberg Cc: ~okias/devicetree@lists.sr.ht, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Das Srinagesh , Robert Marko References: <20220626114634.90850-1-david@ixit.cz> <20220626114634.90850-3-david@ixit.cz> <8704fbd6-94a1-5692-5ccb-95f66ffaaf6f@ixit.cz> From: Krzysztof Kozlowski In-Reply-To: <8704fbd6-94a1-5692-5ccb-95f66ffaaf6f@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/06/2022 19:13, David Heidelberg wrote: > On 26/06/2022 18:45, Krzysztof Kozlowski wrote: >> On 26/06/2022 13:46, David Heidelberg wrote: >>> Convert Qualcomm SCM firmware binding to the yaml format. >>> >>> This commit also: >>> - adds qcom,scm-mdm9607 into list which has only core clock >>> - adds qcom,scm-sm6125, qcom,scm-ipq6018 >>> - #reset-cells, because the property is already used >>> >>> Cc: Robert Marko >>> Cc: Guru Das Srinagesh >>> Signed-off-by: David Heidelberg >>> --- >>> v3: >>> - add preceding patches for ARM and arm64 adding missing compatible strings >>> - extended with missing compatible strings >>> - added two additional maintainers, see https://lkml.org/lkml/2022/6/23/1969 >>> v2: >>> - changed maintainer to Bjorn >>> - document #reset-cells >>> >>> .../devicetree/bindings/firmware/qcom,scm.txt | 57 -------- >>> .../bindings/firmware/qcom,scm.yaml | 131 ++++++++++++++++++ >>> 2 files changed, 131 insertions(+), 57 deletions(-) >>> delete mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.txt >>> create mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt >>> deleted file mode 100644 >>> index 0f4e5ab26477..000000000000 >>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt >>> +++ /dev/null >>> @@ -1,57 +0,0 @@ >>> -QCOM Secure Channel Manager (SCM) >>> - >>> -Qualcomm processors include an interface to communicate to the secure firmware. >>> -This interface allows for clients to request different types of actions. These >>> -can include CPU power up/down, HDCP requests, loading of firmware, and other >>> -assorted actions. >>> - >>> -Required properties: >>> -- compatible: must contain one of the following: >>> - * "qcom,scm-apq8064" >>> - * "qcom,scm-apq8084" >>> - * "qcom,scm-ipq4019" >>> - * "qcom,scm-ipq806x" >>> - * "qcom,scm-ipq8074" >>> - * "qcom,scm-mdm9607" >>> - * "qcom,scm-msm8226" >>> - * "qcom,scm-msm8660" >>> - * "qcom,scm-msm8916" >>> - * "qcom,scm-msm8953" >>> - * "qcom,scm-msm8960" >>> - * "qcom,scm-msm8974" >>> - * "qcom,scm-msm8976" >>> - * "qcom,scm-msm8994" >>> - * "qcom,scm-msm8996" >>> - * "qcom,scm-msm8998" >>> - * "qcom,scm-sc7180" >>> - * "qcom,scm-sc7280" >>> - * "qcom,scm-sdm845" >>> - * "qcom,scm-sdx55" >>> - * "qcom,scm-sm6350" >>> - * "qcom,scm-sm8150" >>> - * "qcom,scm-sm8250" >>> - * "qcom,scm-sm8350" >>> - * "qcom,scm-sm8450" >>> - and: >>> - * "qcom,scm" >>> -- clocks: Specifies clocks needed by the SCM interface, if any: >>> - * core clock required for "qcom,scm-apq8064", "qcom,scm-msm8660" and >>> - "qcom,scm-msm8960" >>> - * core, iface and bus clocks required for "qcom,scm-apq8084", >>> - "qcom,scm-msm8916", "qcom,scm-msm8953", "qcom,scm-msm8974" and "qcom,scm-msm8976" >>> -- clock-names: Must contain "core" for the core clock, "iface" for the interface >>> - clock and "bus" for the bus clock per the requirements of the compatible. >>> -- qcom,dload-mode: phandle to the TCSR hardware block and offset of the >>> - download mode control register (optional) >>> - >>> -Example for MSM8916: >>> - >>> - firmware { >>> - scm { >>> - compatible = "qcom,msm8916", "qcom,scm"; >>> - clocks = <&gcc GCC_CRYPTO_CLK> , >>> - <&gcc GCC_CRYPTO_AXI_CLK>, >>> - <&gcc GCC_CRYPTO_AHB_CLK>; >>> - clock-names = "core", "bus", "iface"; >>> - }; >>> - }; >>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>> new file mode 100644 >>> index 000000000000..17d06e75b82b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>> @@ -0,0 +1,131 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: "http://devicetree.org/schemas/firmware/qcom,scm.yaml#" >>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> No quotes here. >> >>> + >>> +title: QCOM Secure Channel Manager (SCM) >>> + >>> +description: | >>> + Qualcomm processors include an interface to communicate to the secure firmware. >>> + This interface allows for clients to request different types of actions. >>> + These can include CPU power up/down, HDCP requests, loading of firmware, >>> + and other assorted actions. >>> + >>> +maintainers: >>> + - Bjorn Andersson >>> + - Robert Marko >>> + - Guru Das Srinagesh >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - qcom,scm-apq8064 >>> + - qcom,scm-apq8084 >>> + - qcom,scm-ipq4019 >>> + - qcom,scm-ipq6018 >>> + - qcom,scm-ipq806x >>> + - qcom,scm-ipq8074 >>> + - qcom,scm-mdm9607 >>> + - qcom,scm-msm8226 >>> + - qcom,scm-msm8660 >>> + - qcom,scm-msm8916 >>> + - qcom,scm-msm8953 >>> + - qcom,scm-msm8960 >>> + - qcom,scm-msm8974 >>> + - qcom,scm-msm8976 >>> + - qcom,scm-msm8994 >>> + - qcom,scm-msm8996 >>> + - qcom,scm-msm8998 >>> + - qcom,scm-sc7180 >>> + - qcom,scm-sc7280 >>> + - qcom,scm-sdm845 >>> + - qcom,scm-sdx55 >>> + - qcom,scm-sm6125 >>> + - qcom,scm-sm6350 >>> + - qcom,scm-sm8150 >>> + - qcom,scm-sm8250 >>> + - qcom,scm-sm8350 >>> + - qcom,scm-sm8450 >>> + - qcom,scm-qcs404 >>> + - const: qcom,scm >>> + >>> + clocks: >>> + minItems: 1 >>> + maxItems: 3 >>> + >>> + clock-names: true >> You should have constraints here - min/maxItems. >> >>> + >>> + '#reset-cells': >>> + const: 1 >>> + >>> + qcom,dload-mode: >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + items: >>> + - items: >>> + - description: phandle to TCSR hardware block >>> + - description: offset of the download mode control register >>> + description: >>> + Should be phandle/offset pair. >> This description is not helpful. Should be something closer to "TCSR >> hardware block". >> >>> + >>> +allOf: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - qcom,scm-apq8064 >>> + - qcom,scm-mdm9607 >>> + - qcom,scm-msm8660 >>> + - qcom,scm-msm8960 >>> + then: >>> + properties: >>> + clock-names: >>> + items: >>> + - const: core >> Missing constraints (maxItems:2) for clocks. > > Why 2? I would put `maxItems: 1` there > Yes, of course, typo. Best regards, Krzysztof