Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <924eb8a2-a040-0632-872b-e1951c71c169@gmail.com>
Date:   Mon, 27 Jun 2022 09:09:52 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.1
Subject: Re: [PATCH] platform: x86: Remove duplicated include in
 barco-p50-gpio.c
Content-Language: en-GB
To:     Peter Korsgaard <peter@korsgaard.com>
Cc:     santoshkumar.yadav@barco.com, peter.korsgaard@barco.com,
        hdegoede@redhat.com, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        saurav.girepunje@hotmail.com
References: <YriUMDJoip0Mknh3@Sauravs-MacBook-Air.local>
 <8735fr1bqh.fsf@dell.be.48ers.dk>
From:   Saurav Girepunje <saurav.girepunje@gmail.com>
In-Reply-To: <8735fr1bqh.fsf@dell.be.48ers.dk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 27/06/22 12:41 am, Peter Korsgaard wrote:
>>>>>> "Saurav" == Saurav Girepunje <saurav.girepunje@gmail.com> writes:
> 
>  > Remove the duplicate include of linux/io.h in barco-p50-gpio.c
>  > file.
> 
>  > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> 
> What tree is this against? The io.h include in the line just above
> delay.h was already removed by:
> 

I am using git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git .
if it fix on another tree . Please ignore this patch.

> commit 011881b80ebe773914b59905bce0f5e0ef93e7ba
> Author: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Date:   Thu May 26 17:03:45 2022 +0800
> 
>     platform/x86: barco-p50-gpio: Add check for platform_driver_register
> 
>     As platform_driver_register() could fail, it should be better
>     to deal with the return value in order to maintain the code
>     consisitency.
> 
>     Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
>     Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>     Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
>     Link: https://lore.kernel.org/r/20220526090345.1444172-1-jiasheng@iscas.ac.cn
>     Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
>> ---
>  >  drivers/platform/x86/barco-p50-gpio.c | 1 -
>  >  1 file changed, 1 deletion(-)
> 
>  > diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
>  > index f5c72e33f9ae..bb8ed8e95225 100644
>  > --- a/drivers/platform/x86/barco-p50-gpio.c
>  > +++ b/drivers/platform/x86/barco-p50-gpio.c
>  > @@ -14,7 +14,6 @@
>  >  #include <linux/delay.h>
>  >  #include <linux/dmi.h>
>  >  #include <linux/err.h>
>  > -#include <linux/io.h>
>  >  #include <linux/kernel.h>
>  >  #include <linux/leds.h>
>  >  #include <linux/module.h>
>  > --
>  > 2.33.0
> 
>