Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8853a55e32d6b5f5657e521094dbf01e371516fe.camel@intel.com>
Subject: Re: [PATCH v5 00/22] TDX host kernel support
From:   Kai Huang <kai.huang@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     linux-mm@kvack.org, linux-acpi@vger.kernel.org, seanjc@google.com,
        pbonzini@redhat.com, len.brown@intel.com, tony.luck@intel.com,
        rafael.j.wysocki@intel.com, reinette.chatre@intel.com,
        dan.j.williams@intel.com, peterz@infradead.org, ak@linux.intel.com,
        kirill.shutemov@linux.intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com,
        isaku.yamahata@intel.com, akpm@linux-foundation.org,
        thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com,
        rdunlap@infradead.org, Jason@zx2c4.com, juri.lelli@redhat.com,
        mark.rutland@arm.com, frederic@kernel.org, yuehaibing@huawei.com,
        dongli.zhang@oracle.com
Date:   Mon, 27 Jun 2022 16:09:40 +1200
In-Reply-To: <14e3d8cb-5e36-dc90-bfc8-b34a105749a3@intel.com>
References: <cover.1655894131.git.kai.huang@intel.com>
         <14e3d8cb-5e36-dc90-bfc8-b34a105749a3@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-06-24 at 12:47 -0700, Dave Hansen wrote:
> On 6/22/22 04:15, Kai Huang wrote:
> > Please kindly help to review, and I would appreciate reviewed-by or
> > acked-by tags if the patches look good to you.
>=20
> Serious question: Is *ANYONE* looking at these patches other than you
> and the maintainers?  I first saw this code (inside Intel) in early
> 2020.  In that time, not a single review tag has been acquired?
>=20
> $ egrep -ic 'acked-by:|reviewed-by:' kais-patches.mbox
> 0

Hi Dave,

There were big design changes in the history of this series (i.e. we origin=
ally
supported loading both the NP-SEAMLDR ACM and the TDX module during boot, a=
nd we
changed from initializing the module from during kernel boot to at runtime)=
, but
yes some other Linux/KVM TDX developers in our team have been reviewing thi=
s
series during the all time, at least at some extent.  They just didn't give
Reviewed-by or Acked-by.

Especially, after we had agreed that this series in general should enable T=
DX
with minimal code change, Kevin helped to review this series intensively an=
d
helped to simplify the code to the current shape (i.e. TDMR part).  He didn=
't
give any of tags either (only said this series is ready for you to review),
perhaps because he was _helping_ to get this series to the shape that is re=
ady
for you and other Intel reviewers to review.

--=20
Thanks,
-Kai