Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d18a1f18-d78c-2db8-9b19-196dc88978c2@gmail.com>
Date:   Mon, 27 Jun 2022 10:09:11 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 5/5] OPP: Remove custom OPP helper support
Content-Language: en-US
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Keerthy <j-keerthy@ti.com>, Dave Gerlach <d-gerlach@ti.com>,
        Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
        Stephen Boyd <sboyd@kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-pm@vger.kernel.org,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-kernel@vger.kernel.org,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
References: <cover.1653991004.git.viresh.kumar@linaro.org>
 <2e6ee73dbc8a231377547a8e9497561cadb38166.1653991004.git.viresh.kumar@linaro.org>
 <565ff879-11e4-1ae4-08d8-1237a875ef12@gmail.com>
 <20220627060636.rfpok75zydgcwwo6@vireshk-i7>
 <4a8114f7-4ee6-a9ad-f5be-ceaf64be8a0e@gmail.com>
 <20220627064155.jo7iqz5h33l7a4vn@vireshk-i7>
From:   Dmitry Osipenko <digetx@gmail.com>
In-Reply-To: <20220627064155.jo7iqz5h33l7a4vn@vireshk-i7>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

27.06.2022 09:41, Viresh Kumar пишет:
> On 27-06-22, 09:10, Dmitry Osipenko wrote:
>> Okay, but Tegra 3d driver doesn't need config_regulators(), it needs
>> customized set_opp() to set clock rate for both 3d engines.
> 
> What does that mean, you need to set two clocks ? There is separate
> support added for that already [1].
> 

Yes, I missed that multi-clock OPP patch, thanks.

Seems _opp_compare_key() won't work properly for the multi-clocks since
Tegra doesn't have bandwidth nor level for the 3d OPPs. Why does it need
to check opp_table->clk_count == 1? Shouldn't it be opp_table->clk_count
> 0?