Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec9550c2-982f-12b6-e368-2cf94a1dba60@redhat.com>
Date:   Mon, 27 Jun 2022 09:46:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v1] platform/x86: intel/pmc: Add Alder Lake N support to
 PMC core driver
Content-Language: en-US
To:     "Kammela, Gayatri" <gayatri.kammela@linux.intel.com>
Cc:     irenic.rajneesh@gmail.com, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "David E . Box" <david.e.box@linux.intel.com>
References: <20220615002751.3371730-1-gayatri.kammela@linux.intel.com>
 <caaca84e-1cc4-bf81-f705-fdabe2313d71@redhat.com>
 <3fc73477-59e3-2935-489b-d3dbfd77eafc@linux.intel.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <3fc73477-59e3-2935-489b-d3dbfd77eafc@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 6/22/22 19:56, Kammela, Gayatri wrote:
> On 6/22/2022 3:23 AM, Hans de Goede wrote:
> 
>> Hi,
>>
>> On 6/15/22 02:27, Gayatri Kammela wrote:
>>> Add Alder Lake N (ADL-N) to the list of the platforms that Intel's
>>> PMC core driver supports. RocketLake reuses all the TigerLake PCH IPs.
>>>
>>> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
>>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> Cc: David E. Box <david.e.box@linux.intel.com>
>>> Signed-off-by: Gayatri Kammela <gayatri.kammela@linux.intel.com>
>> Thank you for your patch, I've applied this patch to my review-hans
>> branch:
>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>>
>> Note it will show up in my review-hans branch once I've pushed my
>> local branch there, which might take a while.
>>
>> Once I've run some tests on this branch the patches there will be
>> added to the platform-drivers-x86/for-next branch and eventually
>> will be included in the pdx86 pull-request to Linus for the next
>> merge-window.
>>
>> Regards,
>>
>> Hans
> Thank you Hans! I have sent v2 fixing the typo.

Next time please send newer versions before I apply them. I've updated
the version in my review-hans and fixes branches now and done a
forced push of those branches.

Regards,

Hans


>>
>>> ---
>>>   drivers/platform/x86/intel/pmc/core.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
>>> index 40183bda7894..a1fe1e0dcf4a 100644
>>> --- a/drivers/platform/x86/intel/pmc/core.c
>>> +++ b/drivers/platform/x86/intel/pmc/core.c
>>> @@ -1911,6 +1911,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {
>>>       X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L,    &icl_reg_map),
>>>       X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE,        &tgl_reg_map),
>>>       X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L,        &tgl_reg_map),
>>> +    X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_N,        &tgl_reg_map),
>>>       X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE,        &adl_reg_map),
>>>       X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P,        &tgl_reg_map),
>>>       {}
>>>
>>> base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3
>