Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <48b2c4c2-3032-a90b-07c1-f03b3a84df3a@nvidia.com>
Date:   Mon, 27 Jun 2022 13:29:33 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH RESEND v4 07/15] PCI: tegra194: Drop manual DW PCIe
 controller version setup
Content-Language: en-US
To:     Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Jingoo Han <jingoohan1@gmail.com>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
Cc:     Serge Semin <fancer.lancer@gmail.com>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Frank Li <Frank.Li@nxp.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org
References: <20220624143947.8991-1-Sergey.Semin@baikalelectronics.ru>
 <20220624143947.8991-8-Sergey.Semin@baikalelectronics.ru>
From:   Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <20220624143947.8991-8-Sergey.Semin@baikalelectronics.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWdpUmRjSGU5U3owQVBGU2t3VG0zZFJRZGowMHQyRS9Xa3hHb1RIQ1ZTNTgr?=
 =?utf-8?B?MGttQ1VuUklWNDJmUWx3T2I0bTJ2L1FQS3ZFRTE5b2NzVkxXWXV2SzFwKzNO?=
 =?utf-8?B?R0o5VmRxbVVTNlN1aFh4cklJU2s1VTZKUFpaTkRJb1IvKzh4NjJiSVRyVHQz?=
 =?utf-8?B?dm5BRzdvbDZEMCtmdXkzNURWUEFoNHBjOGtlUUROblQrdFZ4amw0Ym91ZitB?=
 =?utf-8?B?aVR1ajVhYk43Y3pMTmlhODFmeXlYaVJGMVI3S1hOamJBY2tkN3p2VE43R0tG?=
 =?utf-8?B?SFZMWW9yL3Q2amVkL0plU1NmMGZQZ00vYk1MWU9OS2JGcldscklKYnpTT3hW?=
 =?utf-8?B?NlRsZVJrWnhqM0JiNjdrb0JhWjcwOGlnMUV5MjRuNFpucmZacTVCbkZKalhJ?=
 =?utf-8?B?M1o0aFpLRDRmOVR0RndtTVZLcGkrdGlDbitzZXc5TGh3OEF4UEIxS0NOQktz?=
 =?utf-8?B?NHNNYTJHU2ZnZTVodmVPQ0s3ZENudml0L0N3V0FqV0t2SG1OZzhGVVh2Vm9s?=
 =?utf-8?B?dVRaek81WlJXZDFUbkx0cGVUb0RYY2hqakRLYzVzWGtvY0dOSzcreTFaeE8z?=
 =?utf-8?B?OWJraG56WS8xUkdxNURJZXg5c2diYzlWSkFGeldzcm50ZVZBdnJKZzg2Qkdm?=
 =?utf-8?B?V3FuOGFXVFVEMkJQNTkrajh1d0hmaDJoNTNSS29yNW1HY2xwWlNIamwzUG5P?=
 =?utf-8?B?eStUN3AzakpDc1Fjd2FDaXplWlBwVkxMTW1jZ3NqWnA2djVncUJya2ZGZ2dq?=
 =?utf-8?B?QlJzSmV3bmoycld2N1Ewb2FvZ24zZkl3YnMyOWhSRjcrUXJwcDNENXhrUDVs?=
 =?utf-8?B?cXExUm40aXRHNkNWZi82Zit5SHVQd3V3MjNsdzcxaE1rVzl4aXJQWnp3RnNa?=
 =?utf-8?B?cnVZckhzRmxkTVJoSnAvOEhwNU5RdzJ4d1V2WTVDOGRJUjZoaktRMjE4eE94?=
 =?utf-8?B?KzBsZlF6N3ZpWUZRRHF0MG5iYVFBUlRqallkQ1Z3Q1NkMnJqWkJRdHcxZjBp?=
 =?utf-8?B?UklxZ280dmRpVE1kb0wxWS9VSnB6aThPcXlsS3RKNTBkakp2VGtXM1Q0MUxv?=
 =?utf-8?B?Y0twd01RNVduc091U2kxbC9wUWFUcGJCMm0vTXplVDBodHhJay9CVTVGQkJL?=
 =?utf-8?B?bkpLMEE1Y3ZQU3RhZFJ2U0dMK3dJR1BvdGlXUDFlbVUySnNwNklPdUJBNHd4?=
 =?utf-8?B?Rk1oRzFmckUzaGM1MkZzNlhtRnRJZ3BGOEtpYkV3QUR0bWhTTk9NTEsvdmN2?=
 =?utf-8?B?RkJ5cllhMFFvSzh4WHVtNkE1Yk5ZcVJJRDhMMTE5eE9rNUN2eUJjaWdjakN2?=
 =?utf-8?B?ZWYwZHMzMU9LQ0k1WE82eGpIVTViWUhudkdUWFNXcFdFV1VhblVHYmJjWmtt?=
 =?utf-8?B?M2Y3YmZoSkVsTWVVTHFjQkp2UWF0Wk9mZ1RuQllhcy8vYUZFd1JuRmV1cEN0?=
 =?utf-8?B?cDdmRWtYaE12NzlTY3M4NVBjbkRlSzJsOCtoQ1BLVEd4Q0UxZHJ0MFdQN3Zl?=
 =?utf-8?B?NXdwaHNkbVVuQXMyZnZCMWRZa1JpR0l6dGRMZ3doOFlVR1ZXdEFVUGtMNnNP?=
 =?utf-8?B?bndHVUQxTHhaYWxld3Q5Ly9tbmNldHdXclo4eURKTTlFQUlocjl0V0xnRkhy?=
 =?utf-8?B?ZUY2V1JWTEUzOElJZTh1ZGtPSGVicVFNMnZMcTZzcWhyZFlKdUdHWTZJeE82?=
 =?utf-8?B?MVFIYkNscFlRaTlYbjVadjkzdVNNNWIyYWVlZ3k1dzBydiswSDdEcEhPeXpH?=
 =?utf-8?B?bnpQVGw1ejUwcVJCSVMybzkyVjNvL0lJb0pVenpIcWRGRXBxd2Jkd21wK1ZF?=
 =?utf-8?B?MkcwanMyUFZzYVdKMW4wUkpycytzcHVOQmRlV2syM0NuVzhVQkIzVFcwRUZJ?=
 =?utf-8?B?WmFVV2wxT1BwakZPb1ZHcnluOTZrdHpEamdXZ1NKWEEyQUZhd0s2NVdVMW9k?=
 =?utf-8?B?a3ZlaFVoSTJjcXpaOEl2ZlhkQ09Ta3FjU0NSS2lWUm9Ub05LdU5hUEJINWNH?=
 =?utf-8?B?cFBZdUVicXVNaGpKZldjN25MeW0rSnBVdmdRbk5QZEcyeEZkR1RVRHZKMW9v?=
 =?utf-8?B?a3ROVzhYUXZiY2FGWU1GSDR3TUhEaWM2Q3N2RmdURTNmbnpSTHkyRTBnbjFo?=
 =?utf-8?Q?yFyX5ImNJBwOAdJRS57Jz5S/F?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10724ea7-015e-4fb7-8277-08da581300ef
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB2900.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 07:59:47.2790
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Omi5RNHpFtqOJSp9gkzKAQRMfBBFCX5xwgczzfJI9qIEZDXOurzEvKbCplgoIhT+zmAGk6zsxwXLEotHKmhRVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0143
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/24/2022 8:09 PM, Serge Semin wrote:
> External email: Use caution opening links or attachments
> 
> 
> Since the DW PCIe common code now supports the IP-core version
> auto-detection there is no point in manually setting the version up for the
> controllers newer than v4.70a. Seeing Tegra 194 PCIe Host and EP
> controllers are based on the DW PCIe v4.90a IP-core we can freely drop the
> dw_pcie.version field initialization.
> 
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> 
> ---
> 
> Folks, I don't have Tegra 194 PCIe hw instance to test it out. Could you
> please make sure this patch doesn't brake anything?

Hi,
I tried to apply the series 
https://patchwork.kernel.org/project/linux-pci/list/?series=653624 on 
top of linux-next and ran into conflicts. Could you please tell me the 
minimum set of patches to be taken?

Thanks,
Vidya Sagar

> 
> Changelog v3:
> - This is a new patch create as a result of the discussion:
>    https://lore.kernel.org/linux-pci/20220503214638.1895-6-Sergey.Semin@baikalelectronics.ru/
> ---
>   drivers/pci/controller/dwc/pcie-tegra194.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index f24b30b7454f..e497e6de8d15 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -1979,7 +1979,6 @@ static int tegra194_pcie_probe(struct platform_device *pdev)
>          pci->ops = &tegra_dw_pcie_ops;
>          pci->n_fts[0] = N_FTS_VAL;
>          pci->n_fts[1] = FTS_VAL;
> -       pci->version = DW_PCIE_VER_490A;
> 
>          pp = &pci->pp;
>          pp->num_vectors = MAX_MSI_IRQS;
> --
> 2.35.1
>