Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2763155iog; Mon, 27 Jun 2022 02:22:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vgybzx+UbqQdSp7gN3WvedMPBvQqmKmsYjv7G1FpaIqFF9LXawZCeTEbeGvPBT+iu/vM09 X-Received: by 2002:a62:aa10:0:b0:525:22bb:b028 with SMTP id e16-20020a62aa10000000b0052522bbb028mr13858434pff.21.1656321736537; Mon, 27 Jun 2022 02:22:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656321736; cv=none; d=google.com; s=arc-20160816; b=AlrcVF74/+7czGZGGCcccIFJBjfg1UyPXP6mm6UnJFrvno97YcdhNIqObD1yNlFrFD guFXac3D7pIzwiAng0jpCkXdT9ONZUv3WR9Bw8DwVcL6rm/3jn11aT5VBQlsxvgpo3CX p5hxX7n6aLq5xkvVc0jxHv/BgVwsKNcg96aeoZEQyY/LqZvNHzsWcWLKw1fjtPMn5kPu IZfOFjGTDwf6cM523q1l/KDDy4j1Jn9J5HzXVbvFWZTPdDtByRvihBzGu8CUkVwv8sG1 VTUq4gU+V/xOr6OyRhwQtTKk8AgR5Vy39+/DkiuHeUvOWcETxE4qGazbd32/Wdgxyym1 fNrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=963NkraK7dEYMM4z2YoaLw6rwznX4KCQYfpKYDI8qbk=; b=bPINFCMK8nlAGe5vtC06vC7NrAqQezcMbE8I7xLvJad89Pb/cU3P4Yoo5DAnHiyhcL SGT8Y2LzSE2FrMJluC5d12s0txEBUwGAVtqZcLcwdVvMWu1PrxFRoqx4ZRpyKxDT46cm fiLobveQ9FcoChGXfT5dJl+0UzXJ0p+U27cGBZmSLmzHm/9iYNwa7EQ3kfLhNsoTkTqW q3FmZVUi0fOEL5kHI8NtXQ4GLEj3e9MB/byFlJQmfumK0YqoSPXJgY7oRHAMHAdAUHzA 5idw5k0L9d6XfJTDBK57fnWw9IDWg1KLWCr00eL543+/CwjmZz7VzyFnhxAEmztSR5KD almQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o28-20020a634e5c000000b00410702fb5f1si1125697pgl.805.2022.06.27.02.22.04; Mon, 27 Jun 2022 02:22:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233423AbiF0I67 (ORCPT + 99 others); Mon, 27 Jun 2022 04:58:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233409AbiF0I65 (ORCPT ); Mon, 27 Jun 2022 04:58:57 -0400 Received: from outbound-smtp14.blacknight.com (outbound-smtp14.blacknight.com [46.22.139.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B7886252 for ; Mon, 27 Jun 2022 01:58:50 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp14.blacknight.com (Postfix) with ESMTPS id 5D3541C4329 for ; Mon, 27 Jun 2022 09:58:48 +0100 (IST) Received: (qmail 23735 invoked from network); 27 Jun 2022 08:58:48 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 27 Jun 2022 08:58:48 -0000 Date: Mon, 27 Jun 2022 09:46:45 +0100 From: Mel Gorman To: Yu Zhao Cc: Andrew Morton , Nicolas Saenz Julienne , Marcelo Tosatti , Vlastimil Babka , Michal Hocko , Hugh Dickins , Marek Szyprowski , LKML , Linux-MM Subject: [PATCH] mm/page_alloc: Replace local_lock with normal spinlock -fix Message-ID: <20220627084645.GA27531@techsingularity.net> References: <20220624125423.6126-1-mgorman@techsingularity.net> <20220624125423.6126-8-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As noted by Yu Zhao, use pcp_spin_trylock_irqsave instead of pcpu_spin_trylock_irqsave. This is a fix to the mm-unstable patch mm-page_alloc-replace-local_lock-with-normal-spinlock.patch Reported-by: Yu Zhao Signed-off-by: Mel Gorman --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 71065b01827b..934d1b5a5449 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3493,7 +3493,7 @@ void free_unref_page(struct page *page, unsigned int order) zone = page_zone(page); pcp_trylock_prepare(UP_flags); - pcp = pcpu_spin_trylock_irqsave(struct per_cpu_pages, lock, zone->per_cpu_pageset, flags); + pcp = pcp_spin_trylock_irqsave(zone->per_cpu_pageset, flags); if (pcp) { free_unref_page_commit(zone, pcp, page, migratetype, order); pcp_spin_unlock_irqrestore(pcp, flags);