Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2776571iog; Mon, 27 Jun 2022 02:41:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uRuv0rbM3rEVJrlcvt07E2WyfUDIjAfR2U6ytJ7JcMH88E04nz/0qvvIg3wFa/sCEcKT7b X-Received: by 2002:a50:fe98:0:b0:435:a8b:c4c3 with SMTP id d24-20020a50fe98000000b004350a8bc4c3mr15126223edt.78.1656322863990; Mon, 27 Jun 2022 02:41:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656322863; cv=none; d=google.com; s=arc-20160816; b=BwBQ0dHu2ZymUypkszhRrOS0yVIjdmUrpxVe0s3jhgUDiPO8pYt/MYp0SCnYEbt+ug jcXM6hahZ3IOXOqX0Eg+I8X828UoZCpTqj6s10LXkeQSQzr4ksG4NlaHeROAAoBFlt8b +cZiJbVOAKb9Lot5UH/C2Ngt5CdnSLnF3kyy6JBhbEgcsTDiy5joFtFid+TFtYby6it3 Q3LajmTlmVeQilgjfKyO3w1Sz1vUagzUF9e+PX6OYDmEq0p2BB5s8SeBXEG2qu3q63Mm uKa5ks4VHN7aV+12LbDq6jODy/8eg0OqsmkzM6RF2pVkpZMnsFIYFloS2iOEwvEqHd/G J6Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=SEv1nUU1jY0pKLJwE3iPS1IJafi3TY1+3l/3atKLKaI=; b=GSEvsnpF80CU4IK3ey+q3mS5NUniapL82Ldn4AmiyEeo93SLkXWPct7X+4eCKegQ5A fW/pIqP+HHUvjQlunZrvghcG+uVP8nY1V+973/HpTyWmC9YV7UQBmOYZsP19uJcyApm2 gIlP2HuJTl5gFObBzal6tbuAaSZ8mPVAaGFa4P2yS7gJN8eTtcp5pGY3RH3VQ/bkZZuM Ku/4J67qS79MHIDGpUxTeQzCvtBQgO2QIxpPNSYcb+x3FdsWl4/lk1ZJ8HMo4n1hRrxP y0WNt3WqyZK0U43iBjFkZe1ZhGxEMjvw+XDZ3uBwxDtnLMJzLJjh5tQ/b6ahYzkAC1CZ GxTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TTJLwhtv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv20-20020a17090760d400b007120a60b38asi14012510ejc.1001.2022.06.27.02.40.39; Mon, 27 Jun 2022 02:41:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TTJLwhtv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234004AbiF0J03 (ORCPT + 99 others); Mon, 27 Jun 2022 05:26:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233702AbiF0J02 (ORCPT ); Mon, 27 Jun 2022 05:26:28 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B09F615D for ; Mon, 27 Jun 2022 02:26:27 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id a13so15528269lfr.10 for ; Mon, 27 Jun 2022 02:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SEv1nUU1jY0pKLJwE3iPS1IJafi3TY1+3l/3atKLKaI=; b=TTJLwhtvbsqhadefjMNFeCvqr5u2g7+axGCHFhgO6zBrdslsceTGKxOzqpzJm63qTj 9DivaoruBYpOMU92umBbDhndB/J3OO4Luat0oDQGuWt5uKP3FcaMASiMt4znEPU1M0hY 6XAEiJLOj2L2/i+M3CZ8M+Jf5jVuuBD84iWc0Rzelo97HF5o1dWlo4EkxQeBIrly5TRy hI5zcBS5R/oLDiy+RgL8sx9/vLm7sP4mLFoJFVMj5cqAQIASYJy9vVK8rI1hSeLg2sKR Pn0omSpTBCiW2X8RXAxrabQbtqdYvifmJnalstYRpUiyeb14wE2emLo+ZxFMc7O0W/RR iz0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SEv1nUU1jY0pKLJwE3iPS1IJafi3TY1+3l/3atKLKaI=; b=FrGgbiWR48XdUfVFwGWFa930aYbaNbC0sjjnsaUoIn9YTotC3+GL8wuG79eslC+bTJ dQhSkd9uQYr/eU8UMThusjU6zUhrvrGGDd+h1TbCc+7Rd/SkgglV13DqW7ot/YpoMb1S 8AjL4jMR8ALk4hbE9YeCtzPd9xOE6wt8WKPDBez/TCrWkHyqley6uKqS5XuuZdozmdSy 1u2qMJzzpVlIza1X0ZmQK2l1FEt/Gtm424RSm+Yu3zPOy5Qr0luZJNOrfNflUdEwhiJo ia4IQhuVWpn7f+c/uTo73cxiPjF1r/3YOQBs8SOzWXjxHjsnrUp0lhQEvXARejm5M2kB q7GQ== X-Gm-Message-State: AJIora80iTFOkHPehgHEN9oIdrKpy/xcAhgtbvbVfr2+PTZG67jMh+K+ X57FArTcidNPsUjory4zw5CHLLAPPY1lN9XtldaUJg== X-Received: by 2002:a19:640e:0:b0:479:5347:b86e with SMTP id y14-20020a19640e000000b004795347b86emr7420410lfb.563.1656321985863; Mon, 27 Jun 2022 02:26:25 -0700 (PDT) MIME-Version: 1.0 References: <20220617014308.4001511-1-windhl@126.com> In-Reply-To: <20220617014308.4001511-1-windhl@126.com> From: Linus Walleij Date: Mon, 27 Jun 2022 11:26:14 +0200 Message-ID: Subject: Re: [PATCH v4] clk: nomadik: Add missing of_node_put() To: Liang He Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2022 at 3:43 AM Liang He wrote: > In nomadik_src_init(), of_find_matching_node() will return a node > pointer with refcount incremented. We should use of_node_put() in > fail path or when it is not used anymore. > > Signed-off-by: Liang He Reviewed-by: Linus Walleij Yours, Linus Walleij